Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustdoc + rust.css preserves line breaks in inline code #19323

Closed
kmcallister opened this issue Nov 25, 2014 · 1 comment · Fixed by #19727
Closed

rustdoc + rust.css preserves line breaks in inline code #19323

kmcallister opened this issue Nov 25, 2014 · 1 comment · Fixed by #19727
Labels
E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@kmcallister
Copy link
Contributor

$ cat foo.md
% title

The first change is to disallow importing macros from an `extern
crate` that is not at the crate root.

$ rustdoc --html-in-header=<(echo '<link rel="stylesheet" href="http://doc.rust-lang.org/rust.css">') -o . foo.md

produces

<p>The first change is to disallow importing macros from an <code>extern
crate</code> that is not at the crate root.</p>

and, since code is white-space: pre-wrap in rust.css, the line break appears in the rendered document. Probably code shouldn't set white-space independently of pre, but I'm not quite sure what the best fix is.

@kmcallister kmcallister added E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. I-papercut labels Nov 25, 2014
@lambda-fairy
Copy link
Contributor

I think we can get away with just removing that line. GitHub collapses whitespace in inline code and no-one complains.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants