New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Specify behavior of functions taking `ToSockAddrs` #22569

Closed

tbu- opened this issue Feb 20, 2015 · 10 comments

Assignees

Labels

A-docs C-bug P-high

Contributor

tbu- commented Feb 20, 2015

Examples of such functions inclde UdpSocket::bind and UdpSocket::send. Is the first address taken, the last, are all addresses taken into consideration...

The text was updated successfully, but these errors were encountered:

kmcallister added A-docs E-easy labels

Member

steveklabnik commented Mar 8, 2015

I'm not 100% sure what this is asking, can you elaborate a bit, please?

Member

alexcrichton commented Mar 8, 2015

Functions that take T: ToSocketAddrs in the std::net module take an object which will be converted to any number of actual SocketAddr types. It's not currently clear what these methods do when there are multiple socket addresses that are resolved to.

For example, TcpStream::connect will attempt to connect to each address in turn (returning the first that succeeds), but UdpSocket::send will only send a datagram to the first address. Furthermore, there are questions like should TcpListener::bind bind to all the addresses or just one?

alexcrichton closed this as completed

alexcrichton reopened this

Member

steveklabnik commented Mar 18, 2015

Is the current behavior the correct one? IE, do we even want to make that guarantee?

Contributor Author

tbu- commented Mar 19, 2015

You could say what it does right now with a remark that it's not stabilized yet.

Member

steveklabnik commented Apr 20, 2015

I'm removing the 'docs' tag until we decide what we want to specify here.

steveklabnik removed the A-docs label

Contributor Author

tbu- commented Apr 20, 2015

@steveklabnik Can you also remove the 'easy' tag?

Aatch removed the E-easy label

Contributor

Aatch commented Apr 8, 2016

Is this still relevant? I don't think we change anything related in a backwards-compatible way.

alexcrichton added A-docs and removed A-libs labels

Member

alexcrichton commented Apr 8, 2016

This is basically just a docs thing now, we need to be sure we specify what happens if multiple addresses are returned.

steveklabnik added the A-docs label

steveklabnik removed the A-docs label

steveklabnik added the P-medium label

steveklabnik added P-high and removed P-medium labels

steveklabnik self-assigned this

Member

steveklabnik commented Jun 7, 2017

Moving to p-high and assigning myself; i'd like to get this resolved in the next release cycle.

Mark-Simulacrum added the C-bug label

frewsxcv assigned frewsxcv and unassigned steveklabnik

frewsxcv mentioned this issue

Rewrite std::net::ToSocketAddrs doc examples. #44117

Merged

frewsxcv added a commit to frewsxcv/rust that referenced this issue


          Rollup merge of rust-lang#44117 - frewsxcv:frewsxcv-to-socket-addrs-e…

e73c354

…xamples, r=QuietMisdreavus

Rewrite `std::net::ToSocketAddrs` doc examples.

in particular:

* show how to create an iterator that yields multiple socket addresses
* show more failing scenarios

done this as preliminary work while investigating rust-lang#22569

note: i haven't run doc tests on my machine for this, so would be good to confirm CI passes before approving

frewsxcv added a commit to frewsxcv/rust that referenced this issue


          Rollup merge of rust-lang#44117 - frewsxcv:frewsxcv-to-socket-addrs-e…

66b5ebd

…xamples, r=QuietMisdreavus

Rewrite `std::net::ToSocketAddrs` doc examples.

in particular:

* show how to create an iterator that yields multiple socket addresses
* show more failing scenarios

done this as preliminary work while investigating rust-lang#22569

note: i haven't run doc tests on my machine for this, so would be good to confirm CI passes before approving

frewsxcv added a commit to frewsxcv/rust that referenced this issue


          Rollup merge of rust-lang#44117 - frewsxcv:frewsxcv-to-socket-addrs-e…

bd093cd

…xamples, r=QuietMisdreavus

Rewrite `std::net::ToSocketAddrs` doc examples.

in particular:

* show how to create an iterator that yields multiple socket addresses
* show more failing scenarios

done this as preliminary work while investigating rust-lang#22569

note: i haven't run doc tests on my machine for this, so would be good to confirm CI passes before approving

frewsxcv added a commit to frewsxcv/rust that referenced this issue


          Rollup merge of rust-lang#44117 - frewsxcv:frewsxcv-to-socket-addrs-e…

eecfa8d

…xamples, r=QuietMisdreavus

Rewrite `std::net::ToSocketAddrs` doc examples.

in particular:

* show how to create an iterator that yields multiple socket addresses
* show more failing scenarios

done this as preliminary work while investigating rust-lang#22569

note: i haven't run doc tests on my machine for this, so would be good to confirm CI passes before approving

arielb1 pushed a commit to arielb1/rust that referenced this issue


          Rollup merge of rust-lang#44117 - frewsxcv:frewsxcv-to-socket-addrs-e…

f550c25

…xamples, r=QuietMisdreavus

Rewrite `std::net::ToSocketAddrs` doc examples.

in particular:

* show how to create an iterator that yields multiple socket addresses
* show more failing scenarios

done this as preliminary work while investigating rust-lang#22569

note: i haven't run doc tests on my machine for this, so would be good to confirm CI passes before approving

arielb1 pushed a commit to arielb1/rust that referenced this issue


          Rollup merge of rust-lang#44117 - frewsxcv:frewsxcv-to-socket-addrs-e…

30907e1

…xamples, r=QuietMisdreavus

Rewrite `std::net::ToSocketAddrs` doc examples.

in particular:

* show how to create an iterator that yields multiple socket addresses
* show more failing scenarios

done this as preliminary work while investigating rust-lang#22569

note: i haven't run doc tests on my machine for this, so would be good to confirm CI passes before approving

frewsxcv mentioned this issue

Expand docs of multi-address behavior of some UDP/TCP APIs. #44209

Merged

Member

frewsxcv commented Aug 31, 2017

Opened a PR for this: #44209

GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this issue


          Rollup merge of rust-lang#44209 - frewsxcv:frewsxcv-addr-other-scenar…

0761f7f

…ios, r=alexcrichton

Expand docs of multi-address behavior of some UDP/TCP APIs.

Fixes rust-lang#22569.

Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this issue


          Rollup merge of rust-lang#44209 - frewsxcv:frewsxcv-addr-other-scenar…

3cd4ea3

…ios, r=alexcrichton

Expand docs of multi-address behavior of some UDP/TCP APIs.

Fixes rust-lang#22569.

bors closed this as completed in

0a716fd

tbu- mentioned this issue

Clarify the behavior of UDP sockets wrt. multiple addresses in connect #44388

Merged

frewsxcv added a commit to frewsxcv/rust that referenced this issue


          Rollup merge of rust-lang#44388 - tbu-:pr_doc_udp_connect_multiple, r…

dc34c64

…=frewsxcv

Clarify the behavior of UDP sockets wrt. multiple addresses in `connect`

CC @frewsxcv rust-lang#22569 rust-lang#44209

frewsxcv added a commit to frewsxcv/rust that referenced this issue


          Rollup merge of rust-lang#44388 - tbu-:pr_doc_udp_connect_multiple, r…

322a731

…=frewsxcv

Clarify the behavior of UDP sockets wrt. multiple addresses in `connect`

CC @frewsxcv rust-lang#22569 rust-lang#44209

GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this issue


          Rollup merge of rust-lang#44388 - tbu-:pr_doc_udp_connect_multiple, r…

95a0696

…=frewsxcv

Clarify the behavior of UDP sockets wrt. multiple addresses in `connect`

CC @frewsxcv rust-lang#22569 rust-lang#44209

frewsxcv added a commit to frewsxcv/rust that referenced this issue


          Rollup merge of rust-lang#44388 - tbu-:pr_doc_udp_connect_multiple, r…

273922f

…=frewsxcv

Clarify the behavior of UDP sockets wrt. multiple addresses in `connect`

CC @frewsxcv rust-lang#22569 rust-lang#44209

frewsxcv added a commit to frewsxcv/rust that referenced this issue


          Rollup merge of rust-lang#44388 - tbu-:pr_doc_udp_connect_multiple, r…

eb45c0a

…=frewsxcv

Clarify the behavior of UDP sockets wrt. multiple addresses in `connect`

CC @frewsxcv rust-lang#22569 rust-lang#44209

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment