Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tracking issue for Std::iter::{once, empty} (RFC 771) #24443

Closed
aturon opened this issue Apr 15, 2015 · 8 comments · Fixed by #25817
Closed

Tracking issue for Std::iter::{once, empty} (RFC 771) #24443

aturon opened this issue Apr 15, 2015 · 8 comments · Fixed by #25817
Labels
B-RFC-approved Blocker: Approved by a merged RFC but not yet implemented.

Comments

@aturon
Copy link
Member

aturon commented Apr 15, 2015

rust-lang/rfcs#771
@aturon aturon added A-libs B-RFC-approved Blocker: Approved by a merged RFC but not yet implemented. labels Apr 15, 2015
@aturon
Copy link
Member Author

aturon commented Apr 15, 2015

cc @XMPPwocky

@XMPPwocky
Copy link
Contributor

Are you OK with just a PR?

@alexcrichton
Copy link
Member

Sure!

@XMPPwocky
Copy link
Contributor

Is it worth writing tests for this? I'm not really sure how it could break, but better safe than sorry I suppose...

@alexcrichton
Copy link
Member

Yeah but just some simple tests would be fine to have

@Stebalien
Copy link
Contributor

@XMPPwocky ping?

@XMPPwocky
Copy link
Contributor

Working on it right now.

On Sat, May 23, 2015 at 11:36 AM, Steven Allen notifications@github.com
wrote:

@XMPPwocky https://github.com/XMPPwocky ping?

—
Reply to this email directly or view it on GitHub
#24443 (comment).

@Stebalien
Copy link
Contributor

Thanks. I had some free time so I thought I'd check.

@XMPPwocky XMPPwocky mentioned this issue May 27, 2015
Merged
bors added a commit that referenced this issue May 30, 2015
@bors
Auto merge of #25817 - XMPPwocky:once_cleanedup, r=alexcrichton
a0f028d 
Closes #24443.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
B-RFC-approved Blocker: Approved by a merged RFC but not yet implemented.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement std::iter::once/empty (RFC 771) XMPPwocky/rust
4 participants
@alexcrichton @Stebalien @aturon @XMPPwocky