Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make vectors and strings not implicitly copyable #2450

Closed
msullivan opened this issue May 25, 2012 · 3 comments
Closed

Make vectors and strings not implicitly copyable #2450

msullivan opened this issue May 25, 2012 · 3 comments
Labels
A-type-system Area: Type system C-enhancement Category: An issue proposing an enhancement or a PR with one.

Comments

@msullivan
Copy link
Contributor

They are unique, and copying them is expensive. It shouldn't happen implicitly. However, we do it a lot, and getting rid of all of them is somewhat daunting...
@msullivan
Copy link
Contributor Author

This is part of #2431.

@Dretch
Copy link
Contributor

Dretch commented May 26, 2012

Would it be possible to somehow only copy them when sending them between tasks, and use reference-counting the rest of the time?

@msullivan
Copy link
Contributor Author

The current plan is to make this configurable with a default of 'not implicitly copyable' and then override the default for all of our existing projects...

bors added a commit to rust-lang-ci/rust that referenced this issue Sep 22, 2022
@bors
Auto merge of rust-lang#2450 - avrong:cargo-metadata, r=oli-obk
44dc49f 
Use cargo_metadata in cargo-miri

Closes rust-lang#2393

Added `cargo_metadata` to `cargo-miri` and changed metadata from manual parsing to `cargo_metadata` invocations. Thus, removed local `Metadata` struct too.

Happy to fix if anything isn't right :)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-type-system Area: Type system C-enhancement Category: An issue proposing an enhancement or a PR with one.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@msullivan @Dretch