Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default for AtomicPtr? #24613

Closed
njwhite opened this issue Apr 19, 2015 · 2 comments · Fixed by #24834
Closed

Default for AtomicPtr? #24613

njwhite opened this issue Apr 19, 2015 · 2 comments · Fixed by #24834
Labels
C-enhancement Category: An issue proposing an enhancement or a PR with one.

Comments

@njwhite
Copy link

njwhite commented Apr 19, 2015

Is there any reason why there isn't an ATOMIC_PTR_INIT (cf ATOMIC_BOOL_INIT, ATOMIC_ISIZE_INIT, &c.) struct? I'd like to use AtomicPtrs in statically-initialized variables - and AtomicPtr is the only atomic class that doesn't implement the Default trait. A std::ptr::null_mut() seems to be a sensible initial value.
@sfackler
Copy link
Member

You can't define generic consts so ATOMIC_PTR_INIT can't be expressed. We can add a Default implementation though.

@steveklabnik steveklabnik added A-libs C-enhancement Category: An issue proposing an enhancement or a PR with one. labels Apr 20, 2015
@steveklabnik
Copy link
Member

/cc @aturon

shepmaster added a commit to shepmaster/rust that referenced this issue Apr 26, 2015
@shepmaster
Provide a Default implementation for AtomicPtr
7c548a2 
Closes rust-lang#24613
@shepmaster shepmaster mentioned this issue Apr 26, 2015
Merged
bors added a commit that referenced this issue Apr 27, 2015
@bors
Auto merge of #24834 - shepmaster:default-atomic-ptr, r=alexcrichton
b772ce6 
Closes #24613
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-enhancement Category: An issue proposing an enhancement or a PR with one.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Provide a Default implementation for AtomicPtr shepmaster/rust
3 participants
@steveklabnik @njwhite @sfackler