Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"assigning to immutable upvar" error is jargony #2591

Closed
catamorphism opened this issue Jun 14, 2012 · 2 comments
Closed

"assigning to immutable upvar" error is jargony #2591

catamorphism opened this issue Jun 14, 2012 · 2 comments
Labels
A-typesystem Area: The type system C-cleanup Category: PRs that clean code up or issues documenting cleanup. C-enhancement Category: An issue proposing an enhancement or a PR with one.

Comments

@catamorphism
Copy link
Contributor

A borrowck error says "assigning to immutable upvar". Not everyone knows what an "upvar" is. It would be better if the error message was less terse: something like "Assigning to immutable variable declared in an enclosing scope". If any other error messages mention "upvar", those should be improved too.
pcwalton added a commit that referenced this issue Jun 15, 2012
@pcwalton
Issue #2591: Fix "upvar" jargon in borrowck error messages
5151c08
@pcwalton
Copy link
Contributor

Agreed, pushed a fix.

pcwalton added a commit that referenced this issue Jun 15, 2012
@pcwalton
Issue #2591: Change "upvar" to "variable declared in an outer block" …
b6ed1de 
…in tests
@msullivan
Copy link
Contributor

So this is fixed, right? I'm closing it.

RalfJung pushed a commit to RalfJung/rust that referenced this issue Oct 22, 2022
@bors
Auto merge of rust-lang#2591 - RalfJung:rustup, r=RalfJung
e7785f6 
Rustup
Aaron1011 pushed a commit to Aaron1011/rust that referenced this issue Jan 6, 2023
@bors
Auto merge of rust-lang#2591 - RalfJung:rustup, r=RalfJung
78e6286 
Rustup
celinval pushed a commit to celinval/rust-dev that referenced this issue Jun 4, 2024
@github-actions
Automatic toolchain upgrade to nightly-2023-06-23 (rust-lang#2591)
ca66814 
Update Rust toolchain from nightly-2023-06-22 to nightly-2023-06-23 without any other source changes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-typesystem Area: The type system C-cleanup Category: PRs that clean code up or issues documenting cleanup. C-enhancement Category: An issue proposing an enhancement or a PR with one.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@pcwalton @msullivan @catamorphism