Rust building is broken for BSD system

[semarie]

Starting with the latest update of LLVM, several BSD system don't be able to build rust anymore.

At least:

• freebsd: http://buildbot.rust-lang.org/builders/auto-freebsd10_64-1/builds/2/steps/compile/logs/stdio
• bitrig: http://buildbot.rust-lang.org/builders/auto-bitrig-64-opt/builds/1186/steps/compile/logs/stdio
• openbsd

The error message is the same of these three platform (here bitrig message):

error: linking with `cc` failed: exit code: 1
note: "cc" "-m64" "-L" "/home/builder/rust-buildbot/slave/auto-bitrig-64-opt/build/obj/x86_64-unknown-bitrig/stage1/lib/rustlib/x86_64-unknown-bitrig/lib" "x86_64-unknown-bitrig/stage1/lib/rustlib/x86_64-unknown-bitrig/lib/std-7e44814b.0.o" "-o" "x86_64-unknown-bitrig/stage1/lib/rustlib/x86_64-unknown-bitrig/lib/libstd-7e44814b.so" "x86_64-unknown-bitrig/stage1/lib/rustlib/x86_64-unknown-bitrig/lib/std-7e44814b.metadata.o" "-Wl,-O1" "-nodefaultlibs" "-Wl,--whole-archive" "/tmp/rustc.M1grNw2xGkYD/libcollections-7e44814b.rlib" "-Wl,--no-whole-archive" "-Wl,--whole-archive" "/tmp/rustc.M1grNw2xGkYD/librand-7e44814b.rlib" "-Wl,--no-whole-archive" "-Wl,--whole-archive" "/tmp/rustc.M1grNw2xGkYD/liballoc-7e44814b.rlib" "-Wl,--no-whole-archive" "-Wl,--whole-archive" "/tmp/rustc.M1grNw2xGkYD/librustc_unicode-7e44814b.rlib" "-Wl,--no-whole-archive" "-Wl,--whole-archive" "/tmp/rustc.M1grNw2xGkYD/liblibc-7e44814b.rlib" "-Wl,--no-whole-archive" "-Wl,--whole-archive" "/tmp/rustc.M1grNw2xGkYD/libcore-7e44814b.rlib" "-Wl,--no-whole-archive" "-L" "x86_64-unknown-bitrig/rt" "-L" "/home/builder/rust-buildbot/slave/auto-bitrig-64-opt/build/obj/x86_64-unknown-bitrig/llvm/Release/lib" "-L" "/home/builder/rust-buildbot/slave/auto-bitrig-64-opt/build/obj/x86_64-unknown-bitrig/stage1/lib/rustlib/x86_64-unknown-bitrig/lib" "-L" "/home/builder/rust-buildbot/slave/auto-bitrig-64-opt/build/obj/.rust/lib/x86_64-unknown-bitrig" "-L" "/home/builder/rust-buildbot/slave/auto-bitrig-64-opt/build/obj/lib/x86_64-unknown-bitrig" "-Wl,-Bstatic" "-Wl,--whole-archive" "-l" "rust_builtin" "-Wl,--no-whole-archive" "-Wl,--whole-archive" "-l" "backtrace" "-Wl,--no-whole-archive" "-Wl,--whole-archive" "-l" "rustrt_native" "-Wl,--no-whole-archive" "-Wl,-Bdynamic" "-l" "pthread" "-l" "c++abi" "-l" "c" "-l" "m" "-shared" "-l" "compiler-rt"
note: /tmp/rustc.M1grNw2xGkYD/libcollections-7e44814b.rlib: member /tmp/rustc.M1grNw2xGkYD/libcollections-7e44814b.rlib(__.SYMDEF) in archive is not an object
cc: error: linker command failed with exit code 1 (use -v to see invocation)

cc: @dhuseby @wg @vhbit @mneumann

[semarie]

It seems that building with archive_format: "".to_string() is enough for workaround and building (in src/librustc_back/target/openbsd_base.rs)

[semarie]

cc @alexcrichton

[nagisa]

Might be relevant #26926

[dhuseby]

@semarie thanks for the work around. Let me check it out on bitrig and freebsd.

[semarie]

The problem is definitively with LLVM writeArchive (as pointed by @nagisa).

I am able to build and pass all checks under openbsd with archive_format: "".to_string() (so using ar for archives, like before).

I am going to test building using "gnu" archive under openbsd (for now, build ok, tests are pending)