Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explain what an "OS string" is in OsStr/OsString docs #30743

Closed
birkenfeld opened this issue Jan 6, 2016 · 5 comments · Fixed by #30758
Closed

Explain what an "OS string" is in OsStr/OsString docs #30743

birkenfeld opened this issue Jan 6, 2016 · 5 comments · Fixed by #30758

Comments

@birkenfeld
Copy link
Contributor

Currently, this is pretty bare: http://doc.rust-lang.org/nightly/std/ffi/struct.OsString.html

Owned, mutable OS strings.

Needs some explanation what an OS string is, and why it is different from C and Rust strings.

@birkenfeld
Copy link
Contributor Author

Actually, the std/ffi/os_str.rs docstring has the needed info, but since this module isn't exported publicly, it is lost to the docs.

What is the best course of action in these cases?

@steveklabnik
Copy link
Member

This is basically part of #29354

@steveklabnik
Copy link
Member

What is the best course of action in these cases?

Just the most straightforward thing: there's work to be done. Just hasn't been done yet.

@birkenfeld
Copy link
Contributor Author

Just the most straightforward thing: there's work to be done. Just hasn't been done yet.

I get that. The question was more like, should the existing text be moved to the structs, or to the module that is exported in the docs?

@steveklabnik
Copy link
Member

Ahh, sorry. So yeah, module-level docs should discuss the module as a whole, the struct docs, just that struct.

Checking out that source you found, yeah, even just moving them to be on the struct itself would be a pretty big improvement; maybe let's say that closes this ticket, and then making them awesome is just part of that metabug. Sound good?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants