unused lang items do not trigger lint #30881
Labels
A-lints
Area: Lints (warnings about flaws in source code) such as unused_mut.
Comments
sanxiyn
added
the
A-lints
|
Dup of #14406 I believe. |
|
Yep. |
durka
added a commit
to durka/rust
that referenced
this issue
Jan 27, 2016
The range desugaring does not use the lang items. Hence I did not add lang items for inclusive ranges. This cleanup commit removes the old unused ones as well. Whether the desugaring _should_ use lang items is another question: see rust-lang#30809. But if we decide on a strategy there we can add back these lang items, and new ones for inclusive ranges. For stage0 we need to keep the attributes as the lang items still exist even if they are never used. This is surprisingly not a breaking change. Unused #[lang] attributes do not even trigger a lint (see rust-lang#30881).
durka
added a commit
to durka/rust
that referenced
this issue
Jan 27, 2016
The range desugaring does not use the lang items. Hence I did not add lang items for inclusive ranges. This cleanup commit removes the old unused ones as well. Whether the desugaring _should_ use lang items is another question: see rust-lang#30809. But if we decide on a strategy there we can add back these lang items, and new ones for inclusive ranges. For stage0 we need to keep the attributes as the lang items still exist even if they are never used. This is surprisingly not a breaking change. Unused #[lang] attributes do not even trigger a lint (see rust-lang#30881).
durka
added a commit
to durka/rust
that referenced
this issue
Feb 27, 2016
The range desugaring does not use the lang items. Hence I did not add lang items for inclusive ranges. This cleanup commit removes the old unused ones as well. Whether the desugaring _should_ use lang items is another question: see rust-lang#30809. But if we decide on a strategy there we can add back these lang items, and new ones for inclusive ranges. For stage0 we need to keep the attributes as the lang items still exist even if they are never used. This is surprisingly not a breaking change. Unused #[lang] attributes do not even trigger a lint (see rust-lang#30881).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
See playpen.
It seems like
#[lang = "foo"], where there is no such lang item "foo", should triggerunused_attributes.The text was updated successfully, but these errors were encountered: