Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bad span for try shorthand #32709

Closed
marcusklaas opened this issue Apr 3, 2016 · 0 comments
Closed

Bad span for try shorthand #32709

marcusklaas opened this issue Apr 3, 2016 · 0 comments
Labels
A-diagnostics Area: Messages for errors, warnings, and lints

Comments

@marcusklaas
Copy link
Contributor

The span associated to the expression in

fn test() {
    a?
}

includes the closing brace, which it should not.

Found this after @erikjohnson mentioned a fatal error in rustfmt here.

I'm working on a patch for this.
@marcusklaas marcusklaas mentioned this issue Apr 3, 2016
Merged
@nagisa nagisa added the A-diagnostics Area: Messages for errors, warnings, and lints label Apr 4, 2016
steveklabnik added a commit to steveklabnik/rust that referenced this issue Apr 6, 2016
@steveklabnik
Rollup merge of rust-lang#32711 - marcusklaas:try-shorthand-span-fix,…
a2a2cfd 
… r=nagisa

Fix the span for try shorthand expressions

My five character contribution to the rust parser! Fixes rust-lang#32709.
bors added a commit that referenced this issue Apr 11, 2016
@bors
Auto merge of #32711 - marcusklaas:try-shorthand-span-fix, r=nagisa
3fb3cf3 
Fix the span for try shorthand expressions

My five character contribution to the rust parser! Fixes #32709.
bors added a commit that referenced this issue Apr 12, 2016
@bors
Auto merge of #32711 - marcusklaas:try-shorthand-span-fix, r=nagisa
28c9fda 
Fix the span for try shorthand expressions

My five character contribution to the rust parser! Fixes #32709.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-diagnostics Area: Messages for errors, warnings, and lints
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nagisa @marcusklaas