Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustdoc: local doc(hidden) type shows in implementors section #33069

Closed
mitaa opened this issue Apr 18, 2016 · 0 comments · Fixed by #33074
Closed

rustdoc: local doc(hidden) type shows in implementors section #33069

mitaa opened this issue Apr 18, 2016 · 0 comments · Fixed by #33074

Comments

@mitaa
Copy link
Contributor

mitaa commented Apr 18, 2016 

#![crate_type="lib"]

pub trait Bar {}

#[doc(hidden)]
pub mod hidden {
    pub struct Foo;
}

// impl shown in `foo::Bar`s implementors section (but without link)
impl Bar for hidden::Foo {}
This was referenced Apr 18, 2016
Merged
Merged
bors added a commit that referenced this issue Apr 21, 2016
@bors
Auto merge of #33074 - mitaa:rdoc-irlst, r=alexcrichton
b5ba592 
rustdoc: Fix the strip-hidden `ImplStripper`

Instead of stripping impls which reference *stripped* items, we keep impls which reference *retained* items. We do this because when we strip an item we immediately return, and do not recurse into it - leaving the contained items non-stripped from the point of view of the `ImplStripper`.

fixes #33069

r? @alexcrichton
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

rustdoc: Fix the strip-hidden ImplStripper mitaa/rust
1 participant
@mitaa