Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dep-info + -Z no-analysis no longer ignore extern crates #33231

Closed
SiegeLord opened this issue Apr 27, 2016 · 2 comments · Fixed by #33450
Closed

dep-info + -Z no-analysis no longer ignore extern crates #33231

SiegeLord opened this issue Apr 27, 2016 · 2 comments · Fixed by #33450

Comments

@SiegeLord
Copy link
Contributor

Compiling this code:

extern crate doesnt_exist;

fn main() {}

With:

rustc -Z no-analysis --emit dep-info -o test.d test.rs

Used to work (and still works with rust 1.7), but recently has started failing (circa rustc 1.10.0-nightly (bd93816 2016-04-25)) with this error:

test.rs:1:1: 1:27 error: can't find crate for `doesnt_exist` [E0463]
test.rs:1 extern crate doesnt_exist;
          ^~~~~~~~~~~~~~~~~~~~~~~~~~
error: aborting due to previous error

This makes that useful combination of flags no longer work. I suspect -Z no-analysis broke again.
@SiegeLord SiegeLord mentioned this issue May 6, 2016
Merged
@sanxiyn sanxiyn changed the title dep-info + -Z no-static-analysis no longer ignore extern crates dep-info + -Z no-analysis no longer ignore extern crates May 9, 2016
SiegeLord pushed a commit to SiegeLord/rust that referenced this issue May 11, 2016
@SiegeLordEx @SiegeLord
Make --emit dep-info work correctly with -Z no-analysis again.
f16eac9 
Previously, it would attempt to resolve some external crates that weren't
necessary for dep-info output.

Fixes rust-lang#33231.
eddyb added a commit to eddyb/rust that referenced this issue May 12, 2016
@eddyb
Rollup merge of rust-lang#33450 - SiegeLord:dep_info_no_analysis, r=nrc
eb5aedf 
Make --emit dep-info work correctly with -Z no-analysis again.

Previously, it would attempt to resolve some external crates that weren't necessary for dep-info output.

Fixes rust-lang#33231.
bors added a commit that referenced this issue May 13, 2016
@bors
Auto merge of #33450 - SiegeLord:dep_info_no_analysis, r=nrc
01ed700 
Make --emit dep-info work correctly with -Z no-analysis again.

Previously, it would attempt to resolve some external crates that weren't necessary for dep-info output.

Fixes #33231.
@jseyfried jseyfried mentioned this issue Jun 1, 2016
Merged
@SiegeLord
Copy link
Contributor Author

So this is broken again. Can this be reopened?

@nrc nrc reopened this Jul 17, 2016
@jseyfried
Copy link
Contributor

c.f. this comment

@nrc nrc closed this as completed Jul 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make --emit dep-info work correctly with -Z no-analysis again. SiegeLord/rust
3 participants
@SiegeLord @nrc @jseyfried