Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add implementations of the io traits using uv async file i/o #3330

Closed
brson opened this issue Aug 31, 2012 · 3 comments
Closed

Add implementations of the io traits using uv async file i/o #3330

brson opened this issue Aug 31, 2012 · 3 comments
Assignees
@brson
Labels
C-enhancement Category: An issue proposing an enhancement or a PR with one.
Milestone
1.0

Comments

@brson
Copy link
Contributor

brson commented Aug 31, 2012

Our current i/o implementation is thread blocking. We need one build around async i/o. I believe uv does or will provide such an interface.
@ghost ghost assigned brson Jun 18, 2013
@pnkfelix
Copy link
Member

visited for bug triage. brson really owns this, so I will assign it to him.

@thestinger
Copy link
Contributor

The I/O stuff is very much in progress so this is still an issue.

@brson
Copy link
Contributor Author

brson commented Oct 30, 2013

As described this is irrelevant since the old I/O traits are dead. Other issues account for the ongoing I/O work better.

@brson brson closed this as completed Oct 30, 2013
RalfJung pushed a commit to RalfJung/rust that referenced this issue Mar 9, 2024
@bors
Auto merge of rust-lang#3330 - RossSmyth:win-fmt, r=RalfJung
f47732b 
Fix .\miri fmt on Windows

This allows .\miri fmt to work on Windows. Closes rust-lang#3317.

To reiterate, the problem with using `miri fmt` on Windows is that the CLI arguments to rustfmt are too long. Currently over 65,000 characters are used in the call to rustfmt, [which is incompatible with Windows](https://devblogs.microsoft.com/oldnewthing/20031210-00/?p=41553) as it is limited to (2^15 - 1) for all arguments plus all env vars.

Two things are done do get around this limit:

1. Call out to cargo-fmt for the crates that exist.
2. Batch rustfmt calls by length

Another alternative would be to just use rustfmt for everything and don't use cargo-fmt for the crates.

I don't know how much you guys may care about `miri fmt` time to run. I don't know the diff as it did not work before on my computer.

[I have another branch that solves this, but in a less permanent way](RossSmyth/miri/tree/windows-fmt). That was my initial attempt, and I learned that even with cargo-fmt and relative paths, the rustfmt call still has 27k characters. This is closer to the limit than I expected, so it would not be a permanent solution. So I went back to absolute paths & batching.
jaisnan pushed a commit to jaisnan/rust-dev that referenced this issue Jul 29, 2024
@dependabot
Bump tests/perf/s2n-quic from 37335c1 to cd20ac1 (rust-lang#3330)
34820bd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@brson brson

Labels
C-enhancement Category: An issue proposing an enhancement or a PR with one.
Projects
None yet
Milestone
1.0
Development

No branches or pull requests
3 participants
@brson @pnkfelix @thestinger