Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change key binding for "expand all" in docs #33791

Closed
GuillaumeGomez opened this issue May 22, 2016 · 3 comments
Closed

Change key binding for "expand all" in docs #33791

GuillaumeGomez opened this issue May 22, 2016 · 3 comments
Labels
T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@GuillaumeGomez
Copy link
Member

#33765 introduced a feature to expand all docs at once with the '+' key. However, if you want to zoom in for example, it'll expand all as well. Another key combo should be added.

cc @alex-ozdemir
cc @Manishearth
@alex-ozdemir
Copy link
Contributor

Any thoughts on what key would be best?

@alex-ozdemir alex-ozdemir mentioned this issue May 22, 2016
Merged
@GuillaumeGomez
Copy link
Member Author

Adding another key to the "+" I guess? Something like "SHIFT+'+'" maybe?

@alex-ozdemir
Copy link
Contributor

Moving this conversation to the new PR.

GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this issue May 24, 2016
@GuillaumeGomez
Rollup merge of rust-lang#33797 - alex-ozdemir:rustdoc, r=GuillaumeGomez
1e4a77b 
Changed toggle all sections key to `T`

Allows both `T` and `t`.

It had been [Shift]+[+] before.

In response to rust-lang#33791.

cc @Manishearth
r? @GuillaumeGomez
@steveklabnik steveklabnik added the T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. label May 24, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@steveklabnik @GuillaumeGomez @alex-ozdemir