Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

include! uses the wrong search path when it is inside an asm! macro invocation #34812

Closed
jseyfried opened this issue Jul 14, 2016 · 2 comments · Fixed by #34816
Closed

include! uses the wrong search path when it is inside an asm! macro invocation #34812

jseyfried opened this issue Jul 14, 2016 · 2 comments · Fixed by #34816

Comments

@jseyfried
Copy link
Contributor

jseyfried commented Jul 14, 2016 •
edited
Loading

For example, include_str! invocation here in this expansion should search in src/arch but instead searches in src/arch/x86.
@jseyfried
Copy link
Contributor Author

cc @Ericson2314

@jseyfried jseyfried changed the title codemap.source_span() is not always accurate codemap.source_callsite() is not always accurate Jul 14, 2016
@jseyfried
Copy link
Contributor Author

jseyfried commented Jul 14, 2016 •
edited
Loading

It looks like this is a problem with ext::base::expr_to_string.

@jseyfried jseyfried changed the title codemap.source_callsite() is not always accurate include! uses the wrong search path when it is inside an asm! macro invocation Jul 14, 2016
@jseyfried jseyfried mentioned this issue Jul 14, 2016
Merged
bors added a commit that referenced this issue Jul 16, 2016
@bors
Auto merge of #34816 - jseyfried:fix_include_path, r=nrc
eb196dc 
Fix `include!()`s inside `asm!()` invocations

Fixes #34812, a regression caused by #33749 that was not fixed in #34450.
r? @nrc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix include!()s inside asm!() invocations jseyfried/rust
1 participant
@jseyfried