-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change mipsel-musl to soft float #34922
Comments
Just to mirror what I said in the PR which spawned this issue, I’m against changing this target to soft-float before we collect information on what ABI conventional linux distributions, and not OpenWRT, use. |
For what its worth, the Debian MIPS ports are all hard-float. |
Ok, I've published |
@nagisa, are those ports musl based or glibc based? |
@japaric while Debian itself uses I guess since musl is built-in and linked to statically, either soft and hard float will be correct… as long as the binary doesn’t link to any other library from the system. At that point the actual libc the distro is based on ends up not mattering much, but the FP ABI does. |
@nagisa Ohh, I thought you were suggesting running
The |
Yes, I was. I had produced a I’d rather make my own TL;DR: pretty much all I’m unhappy about is the naming of soft-fp MIPS targets.
Which makes
FP ABI used matter all, rather than some of the time. |
Ok, buildbot is restarted, next patch should be good to land! |
switch mipsel-musl to soft float Closes #34922. r? @alexcrichton
It was pointed out by @japaric that the mipsel-musl toolchain should use soft float like the mips-musl toolchain as almost all devices it targets all have soft float. Changing this will require a few pieces:
+soft-float
to the target-features of the mipsel-musl target spec, like the mips-musl target specI'm gonna tag this as E-easy as it's pretty clear how to proceed, and I can help out anyone willing to do so! You even get to play around with our infrastructure a bit :)
The text was updated successfully, but these errors were encountered: