injected code results in errors that emacs hates #3530
Comments
|
In general I think "pointing to source files on disk" isn't going to work so well, since it implies the end-user has a source-file. I'd prefer not to be shipping .rs files as part of the end-user distribution / |
|
Bumping to 0.7; this seems like low priority compared to the million and one traits bugs. |
|
Not critical for 0.7. Nominating for milestone 5, production-ready. |
|
should say something that does not make emacs mad, but there is no file to point to. |
|
accepted for production-ready milestone |
|
still relevant |
|
these macro errors produce a "note: expansion site" message, right? perhaps the emacs plugin could be configured to recognise a string such as "" and look for the expansion site message below. |
|
part of #8793 |
|
assigning P-low. |
|
Triage: I don't use emacs, but these errors are the same, so I'm guessing this is still the same. |
|
Moved to rust-lang/rust-mode#4 |
Changes: ```` rustup rust-lang#52994 Fix test Line length fix Remove references to sized for end users Remove DUMMY_SP Add suggestion for replacement Update lint definitions Lint for Vec<Box<T: Sized>> - Closes rust-lang#3530 Fix doc_markdown mixed case false positive question_mark: Suggest Some(opt?) for if-else redundant_field_names: Do not trigger on path with type params question_mark: Lint only early returns question_mark: Fix applicability Remove obsolete comment new_without_default, partialeq_ne_impl: Use span_lint_node Update .stderr after rebase cargo fmt and remove stabilized feature Make suggestion Applicability::MachineApplicable Address review feedback Extract method Check array lengths to prevent OOB access Add suggestion for explicit_write lint Fix write_with_newline escaping false positive ````
submodules: update clippy from b7a431e to a416c5e Changes: ```` rustup #52994 Fix test Line length fix Remove references to sized for end users Remove DUMMY_SP Add suggestion for replacement Update lint definitions Lint for Vec<Box<T: Sized>> - Closes #3530 Fix doc_markdown mixed case false positive question_mark: Suggest Some(opt?) for if-else redundant_field_names: Do not trigger on path with type params question_mark: Lint only early returns question_mark: Fix applicability Remove obsolete comment new_without_default, partialeq_ne_impl: Use span_lint_node Update .stderr after rebase cargo fmt and remove stabilized feature Make suggestion Applicability::MachineApplicable Address review feedback Extract method Check array lengths to prevent OOB access Add suggestion for explicit_write lint Fix write_with_newline escaping false positive ```` make toolstate green again
Add a test for rust-lang#2941.
Don’t print `Preparing a sysroot` when `-q`/`--quiet` is passed Resolves rust-lang#3530. This also fixes a typo in `cargo miri --help` that I found while trying to run the `--print-sysroot` example.
For example:
Emacs wants to load
<core-macros>and interrupts your workflow to prompt for it. Injected code should come from files on disk (like intrinsic.rs) and we should use the correct file path when inserting them into the AST, so that the error messages work.Alternately, we can come up with another way to indicate injected code so that the diagnostic emitter can generate error messages that emacs doesn't complain about. This could be a better solution, since getting dumped into core_macros.rs may not be so useful.
The text was updated successfully, but these errors were encountered: