Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E0323 needs to be updated to new format #35325

Closed
sophiajt opened this issue Aug 4, 2016 · 0 comments
Closed

E0323 needs to be updated to new format #35325

sophiajt opened this issue Aug 4, 2016 · 0 comments
Labels
A-diagnostics Area: Messages for errors, warnings, and lints E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion.

Comments

@sophiajt
Copy link
Contributor

sophiajt commented Aug 4, 2016

From: src/test/compile-fail/impl-wrong-item-for-trait.rs

Error E0323 needs a span_label, updated title, and a note, updating it from:

error[E0323]: item `bar` is an associated const, which doesn't match its trait `<FooConstForMethod as Foo>`
  --> src/test/compile-fail/impl-wrong-item-for-trait.rs:22:5
   |
22 |     const bar: u64 = 1;
   |     ^^^^^^^^^^^^^^^^^^^

To:

error[E0323]: item `bar` is an associated const, which doesn't match its trait
  --> src/test/compile-fail/impl-wrong-item-for-trait.rs:22:5
   |
22 |     const bar: u64 = 1;
   |     ^^^^^^^^^^^^^^^^^^^ does not match trait
   |
   = note: matching trait `<FooConstForMethod as Foo>`

Bonus: show the original part of the trait that conflicts:

error[E0323]: item `bar` is an associated const, which doesn't match its trait
  --> src/test/compile-fail/impl-wrong-item-for-trait.rs:22:5
   |
14 |    fn bar(&self);
   |    -------------- original trait requirement
...
22 |     const bar: u64 = 1;
   |     ^^^^^^^^^^^^^^^^^^^ does not match trait
   |
   = note: matching trait `<FooConstForMethod as Foo>`
@sophiajt sophiajt added E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. A-diagnostics Area: Messages for errors, warnings, and lints E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion. labels Aug 4, 2016
sophiajt pushed a commit to sophiajt/rust that referenced this issue Aug 5, 2016
eddyb added a commit to eddyb/rust that referenced this issue Aug 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-diagnostics Area: Messages for errors, warnings, and lints E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion.
Projects
None yet
Development

No branches or pull requests

1 participant