Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E0221 needs to be updated to new format #35386

Closed
sophiajt opened this issue Aug 5, 2016 · 3 comments
Closed

E0221 needs to be updated to new format #35386

sophiajt opened this issue Aug 5, 2016 · 3 comments
Labels
A-diagnostics Area: Messages for errors, warnings, and lints E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion.

Comments

@sophiajt
Copy link
Contributor

sophiajt commented Aug 5, 2016

From: src/test/compile-fail/E0221.rs

Error E0221 needs a span_label, updating it from:

error[E0221]: ambiguous associated type `A` in bounds of `Self`
  --> src/test/compile-fail/E0221.rs:21:16
   |
21 |         let _: Self::A; //~ ERROR E0221
   |                ^^^^^^^
   |
note: associated type `Self` could derive from `Foo`
  --> src/test/compile-fail/E0221.rs:21:16
   |
21 |         let _: Self::A; //~ ERROR E0221
   |                ^^^^^^^
note: associated type `Self` could derive from `Bar`
  --> src/test/compile-fail/E0221.rs:21:16
   |
21 |         let _: Self::A; //~ ERROR E0221
   |                ^^^^^^^

To:

error[E0221]: ambiguous associated type `A` in bounds of `Self`
  --> src/test/compile-fail/E0221.rs:21:16
   |
21 |         let _: Self::A; //~ ERROR E0221
   |                ^^^^^^^ ambiguous associated type `A`
   |
note: associated type `Self` could derive from `Foo`
  --> src/test/compile-fail/E0221.rs:21:16
   |
21 |         let _: Self::A; //~ ERROR E0221
   |                ^^^^^^^
note: associated type `Self` could derive from `Bar`
  --> src/test/compile-fail/E0221.rs:21:16
   |
21 |         let _: Self::A; //~ ERROR E0221
   |                ^^^^^^^
@sophiajt sophiajt added E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. A-diagnostics Area: Messages for errors, warnings, and lints E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion. labels Aug 5, 2016
sophiajt pushed a commit to sophiajt/rust that referenced this issue Aug 8, 2016
…nathandturner

Updated Error mesage to new format for E0221

Part of rust-lang#35386
r? @jonathandturner
@tvladyslav
Copy link
Contributor

tvladyslav commented Aug 9, 2016

e0221_1
@jonathandturner Is it expected result?

@sophiajt
Copy link
Contributor Author

sophiajt commented Aug 9, 2016

@crypto-universe - yes, that's expected. Though, as you probably suspect, it's not ideal. Would be great to know where the other possibilities are coming from.

I didn't put the bonus on here, but if you wanted to try to tackle a bonus, you could see if the information is available to see where those types are coming from.

@tvladyslav
Copy link
Contributor

tvladyslav commented Aug 9, 2016

@jonathandturner Got the idea. I'll spend some time on this. Wait with merging, please.

steveklabnik added a commit to steveklabnik/rust that referenced this issue Aug 10, 2016
…nathandturner

Updated Error mesage to new format for E0221

Part of rust-lang#35386
r? @jonathandturner
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-diagnostics Area: Messages for errors, warnings, and lints E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion.
Projects
None yet
Development

No branches or pull requests

2 participants