Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E0232 needs to be updated to new format #35795

Closed
sophiajt opened this issue Aug 18, 2016 · 0 comments
Closed

E0232 needs to be updated to new format #35795

sophiajt opened this issue Aug 18, 2016 · 0 comments

Comments

@sophiajt
Copy link
Contributor

sophiajt commented Aug 18, 2016

From: src/test/compile-fail/E0232.rs

E0232 needs a span_label, updated title, and a note, updating it from:

error[E0232]: this attribute must have a value, eg `#[rustc_on_unimplemented = "foo"]`
  --> src/test/compile-fail/E0232.rs:13:1
   |
13 | #[rustc_on_unimplemented] //~ ERROR E0232
   | ^^^^^^^^^^^^^^^^^^^^^^^^^

to:

error[E0232]: this attribute must have a value
  --> src/test/compile-fail/E0232.rs:13:1
   |
13 | #[rustc_on_unimplemented] //~ ERROR E0232
   | ^^^^^^^^^^^^^^^^^^^^^^^^^ attribute requires a value
   |
   = note: eg `#[rustc_on_unimplemented = "foo"]`
sophiajt pushed a commit to sophiajt/rust that referenced this issue Aug 19, 2016
Update error format for E0232

Fixes rust-lang#35795, as part of rust-lang#35233.

Excited to make my first contribution to rustc!

r? @jonathandturner
sophiajt pushed a commit to sophiajt/rust that referenced this issue Aug 19, 2016
Update error format for E0232

Fixes rust-lang#35795, as part of rust-lang#35233.

Excited to make my first contribution to rustc!

r? @jonathandturner
sophiajt pushed a commit to sophiajt/rust that referenced this issue Aug 20, 2016
Update error format for E0232

Fixes rust-lang#35795, as part of rust-lang#35233.

Excited to make my first contribution to rustc!

r? @jonathandturner
sophiajt pushed a commit to sophiajt/rust that referenced this issue Aug 20, 2016
Update error format for E0232

Fixes rust-lang#35795, as part of rust-lang#35233.

Excited to make my first contribution to rustc!

r? @jonathandturner
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant