Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ICH: Function unsafety does not affect incr. comp. hash #36914

Closed
michaelwoerister opened this issue Oct 2, 2016 · 3 comments
Closed

ICH: Function unsafety does not affect incr. comp. hash #36914

michaelwoerister opened this issue Oct 2, 2016 · 3 comments
Labels
A-incr-comp Area: Incremental compilation
Milestone
Incremental compi...

Comments

@michaelwoerister
Copy link
Member

See #36812 (comment)
@michaelwoerister michaelwoerister added the A-incr-comp Area: Incremental compilation label Oct 2, 2016
@jonas-schievink jonas-schievink mentioned this issue Oct 2, 2016
Closed
@retep998
Copy link
Member

retep998 commented Oct 3, 2016

Does function unsafety actually affect the generated code? Shouldn't it only affect whether you're allowed to perform certain operations?

@michaelwoerister
Copy link
Member Author

I don't think it does yet but it likely will in the future because the compiler will be more conservative regarding optimizations around unsafe code. I think there's some information o that in http://smallcultfollowing.com/babysteps/blog/2016/05/27/the-tootsie-pop-model-for-unsafe-code.

Another thing to consider is that at some point we will cache more than just machine code, so if something influences just analysis, we also have to be able to track it.

@michaelwoerister michaelwoerister mentioned this issue Oct 3, 2016
Merged
MathieuBordere pushed a commit to MathieuBordere/rust that referenced this issue Oct 4, 2016
ICH - Include omitted elements in inc. comp. hash rust-lang#36914
bc382e3
@MathieuBordere MathieuBordere mentioned this issue Oct 4, 2016
Closed
MathieuBordere pushed a commit to MathieuBordere/rust that referenced this issue Oct 5, 2016
ICH - Include omitted elements in inc. comp. hash rust-lang#36914
e051eb3
@MathieuBordere MathieuBordere mentioned this issue Oct 5, 2016
Merged
sophiajt pushed a commit to sophiajt/rust that referenced this issue Oct 6, 2016
Rollup merge of rust-lang#36974 - MathieuBordere:mb/36812_ICHFunction…
2c8c0de 
…Interfaces, r=michaelwoerister

Mb/36812 ich function interfaces

r? @michaelwoerister

This PR contains fixes for rust-lang#36812 and rust-lang#36914
@nikomatsakis nikomatsakis modified the milestones: Launch MIR into Orbit, Incremental compilation alpha Oct 12, 2016
@michaelwoerister
Copy link
Member Author

Fixed by #36974 with additional tests in #37072.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-incr-comp Area: Incremental compilation
Projects
None yet
Milestone
Incremental compilation beta
Development

No branches or pull requests
3 participants
@nikomatsakis @retep998 @michaelwoerister