Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pluralise '1 type parameters' in errors #37042

Closed
Wilfred opened this issue Oct 8, 2016 · 2 comments
Closed

Pluralise '1 type parameters' in errors #37042

Wilfred opened this issue Oct 8, 2016 · 2 comments
Labels
A-diagnostics Area: Messages for errors, warnings, and lints

Comments

@Wilfred
Copy link
Contributor

Wilfred commented Oct 8, 2016

Given the code:

fn too_many_type_params() -> Option<i64, i64> {
    None
}

rustc reports:

error[E0244]: wrong number of type arguments
 --> <anon>:1:30
  |
1 | fn too_many_type_params() -> Option<i64, i64> {
  |                              ^^^^^^^^^^^^^^^^ expected 1 type arguments, found 2

Ideally error messages would use correct plurals, so 'expected 1 type argument, found 2' in this case.
@TimNN TimNN added the A-diagnostics Area: Messages for errors, warnings, and lints label Oct 8, 2016
zackmdavis added a commit to zackmdavis/rust that referenced this issue Oct 15, 2016
@zackmdavis
correct erroneous pluralization of '1 type argument' error messages
ac42f3f 
This is in the matter of rust-lang#37042.
@zackmdavis zackmdavis mentioned this issue Oct 15, 2016
Merged
eddyb added a commit to eddyb/rust that referenced this issue Oct 19, 2016
@eddyb
Rollup merge of rust-lang#37193 - zackmdavis:pluralization_of_expecte…
46de940 
…d_type_arguments, r=nrc

correct erroneous pluralization of '1 type argument' error messages

This is in the matter of rust-lang#37042.
eddyb added a commit to eddyb/rust that referenced this issue Oct 19, 2016
@eddyb
Rollup merge of rust-lang#37193 - zackmdavis:pluralization_of_expecte…
c38324d 
…d_type_arguments, r=nrc

correct erroneous pluralization of '1 type argument' error messages

This is in the matter of rust-lang#37042.
@zackmdavis
Copy link
Member

I guess I should start remembering to use "fixes" or "resolves" language so that GitHub can close these automatically.

@Wilfred Wilfred closed this as completed Jan 11, 2017
@Wilfred
Copy link
Contributor Author

Wilfred commented Jan 11, 2017

Let me do the honours :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-diagnostics Area: Messages for errors, warnings, and lints
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Wilfred @zackmdavis @TimNN