Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make anonymous traits only implementable in the same module that declared the type #3785

Closed
pcwalton opened this issue Oct 16, 2012 · 6 comments
Closed

Make anonymous traits only implementable in the same module that declared the type #3785

pcwalton opened this issue Oct 16, 2012 · 6 comments
Labels
A-resolve Area: Name/path resolution done by `rustc_resolve` specifically

Comments

@pcwalton
Copy link
Contributor

What it says. Resolve is hard otherwise.
@brson
Copy link
Contributor

brson commented Oct 22, 2012

Fine by me.

@catamorphism
Copy link
Contributor

@pcwalton Is this still relevant? (do we even have anonymous traits?)

@catamorphism
Copy link
Contributor

Closing -- I don't think we have anonymous traits.

@thestinger
Copy link
Contributor

Maybe it means anonymous implementations?

@catamorphism
Copy link
Contributor

@thestinger Maybe so; in that case, anon impls already have to be in the same crate that declared the type. Not sure whether tighting the restriction to "same module" improves anything?

@apoelstra apoelstra mentioned this issue Jul 4, 2014
Closed
@apoelstra
Copy link
Contributor

#15060 is an example of a problem caused by the current behaviour.

@adrientetar adrientetar mentioned this issue Jul 5, 2014
Merged
arielb1 pushed a commit to arielb1/rust that referenced this issue Apr 10, 2015
@apoelstra
RFC to require impl MyStruct to be in the same module as the defini…
d38d12d 
…tion of `MyStruct`

This fixes rust-lang#15060 and rust-lang#3785.
bors pushed a commit to rust-lang-ci/rust that referenced this issue May 15, 2021
@rchaser53 @topecongiro
fix internal error when using rustfmt::skip with newline on stmt (rus…
789a097 
…t-lang#3785)
@Kingcrypto38 Kingcrypto38 mentioned this issue Apr 3, 2024
Open
@aravindb26 aravindb26 mentioned this issue Apr 3, 2024
Open
RalfJung pushed a commit to RalfJung/rust that referenced this issue Aug 5, 2024
@bors
Auto merge of rust-lang#3785 - rust-lang:rustup-2024-08-03, r=RalfJung
47aea6f 
Automatic Rustup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-resolve Area: Name/path resolution done by `rustc_resolve` specifically
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@brson @pcwalton @catamorphism @apoelstra @thestinger