-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
debuginfo-gdb tests fail: <error reading variable> #39522
Comments
In case this is not going to be fixed - after test caching lands, these tests will be skippable by |
The problem here is that when gdb gained native rust support, there were still some bugs in that support. When the debug info tests got updated for gdb with native rust support, those bugs were fixed, however this means that there are some versions of gdb which still exhibit those bugs, meaning some tests will fail. These failing tests were meant to be ignored for buggy gdb versions in #39039, that only gdb up to 7.12 was ignored. The best fix would probably be to update the list of ignored versions to include 7.12.1 (I'll send a PR for that). |
ignore more gdb versions with buggy rust support This extends the versions of gdb which were ignored in rust-lang#39039. While just ignoring gdb versions up to 7.12.1 would have been sufficient for now, I believe (after consulting https://sourceware.org/gdb/wiki/Internals%20Versions) that ignoring versions up to 7.12.9 will prevent the tests failing again for 7.12.2, etc. while still running all tests for the development versions of gdb (which will be >= 7.12.10 as far as I can tell). This should fix rust-lang#39522. cc @Manishearth, @michaelwoerister, rust-lang#38948
ignore more gdb versions with buggy rust support This extends the versions of gdb which were ignored in rust-lang#39039. While just ignoring gdb versions up to 7.12.1 would have been sufficient for now, I believe (after consulting https://sourceware.org/gdb/wiki/Internals%20Versions) that ignoring versions up to 7.12.9 will prevent the tests failing again for 7.12.2, etc. while still running all tests for the development versions of gdb (which will be >= 7.12.10 as far as I can tell). This should fix rust-lang#39522. cc @Manishearth, @michaelwoerister, rust-lang#38948
ignore more gdb versions with buggy rust support This extends the versions of gdb which were ignored in rust-lang#39039. While just ignoring gdb versions up to 7.12.1 would have been sufficient for now, I believe (after consulting https://sourceware.org/gdb/wiki/Internals%20Versions) that ignoring versions up to 7.12.9 will prevent the tests failing again for 7.12.2, etc. while still running all tests for the development versions of gdb (which will be >= 7.12.10 as far as I can tell). This should fix rust-lang#39522. cc @Manishearth, @michaelwoerister, rust-lang#38948
On this, I ran into the issue while doing testing on powerpc64le and debugged it in parallel to this issue getting resolved. I've installed gdb from the tip of binutils-gdb master, which is reporting its version as 7.12.50.DATE, and the tests are still being ignored.
Invoking
From the commit we should be only ignoring versions 7.11.90-7.12.9, so it seems something is still wrong. Further, the test suite makes gdb source the in-tree rust pretty printers. It seems that with a version of Rust prior to this fix to ignore "broken" gdb versions we can make the tests pass by breaking the import of the in-tree pretty printer scripts:
Given the rust support in gdb is tested based on gdb's version and not by gdb's output, this says to me that the I didn't dive too deeply into the pretty-printer scripts so maybe there's more to the story. |
I've pushed up a commit at amboar/rust@67bffe3 that "fixes" the expectations. The patch was generated by a script, and the script is included in the commit message so people can roughly reproduce. I had to switch between enabling and disabling the |
I'm no expert when it comes to the debuginfo tests, however:
Can you post a more complete log? I'm especially interested in the output of the failed test. |
@TimNN yeah something's pretty fishy here, I think I'll start a new issue rather than hijack this one any further. |
This is really annoying because I haven't done a successful
./x.py test
in months and it's causing me to submit shitty broken PRs.I'm on NixOS with gdb-7.12.1. When running the test suite I get (with some cruft omitted):
The text was updated successfully, but these errors were encountered: