Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nightly rustc 1.17.0-nightly (ea7a6486a 2017-02-04) crashes #39569

Closed
vorner opened this issue Feb 5, 2017 · 6 comments
Closed

Nightly rustc 1.17.0-nightly (ea7a6486a 2017-02-04) crashes #39569

vorner opened this issue Feb 5, 2017 · 6 comments
Labels
A-incr-comp Area: Incremental compilation

Comments

@vorner
Copy link
Contributor

vorner commented Feb 5, 2017

Today, nightly crashed on me when compiling my code: https://travis-ci.org/vorner/tokio-jsonrpc/jobs/198610271. I don't know what part of the code (vorner/tokio-jsonrpc@3872c1f) is causing this and I don't know how to search for it.

Compilation locally works correctly, with yesterday's or today's nightly. I'm trying that CARGO_INCREMENTAL=1 new feature.

I managed to get this version info from travis in another job:

rustc 1.17.0-nightly (ea7a6486a 2017-02-04)
binary: rustc
commit-hash: ea7a6486a26af085862cd7a5596bb69e83d85e12
commit-date: 2017-02-04
host: x86_64-unknown-linux-gnu
release: 1.17.0-nightly
LLVM version: 3.9

I guess that travis log contains all the relevant information, but if not, please tell me what you need to know.

@est31
Copy link
Member

est31 commented Feb 5, 2017

@vorner most likely the cause is CARGO_INCREMENTAL. Can you remove the target directory and rebuild without it?

@vorner
Copy link
Contributor Author

vorner commented Feb 5, 2017

That seems to have helped… I added cargo clean to the job specification and now it passes. I didn't know travis keeps the directories intact between builds.

The new log is https://travis-ci.org/vorner/tokio-jsonrpc/jobs/198619831. But I guess that makes it even harder to find out what is wrong.

vorner added a commit to vorner/tokio-jsonrpc that referenced this issue Feb 5, 2017
They are broken currently, wait until they are fixed.

rust-lang/rust#39569
@michaelwoerister
Copy link
Member

Thanks for the bug report. This seems to be a problem with our new dependency graph reduction algorithm introduced in #39424.

@nikomatsakis
Copy link
Contributor

@vorner I believe this was fixed -- can you verify?

@vorner
Copy link
Contributor Author

vorner commented Feb 23, 2017

I couldn't reproduce it reliably, it only crashed from time to time, so I have no way to explicitly verify it's fixed. But I haven't seen it crash for quite some time now, so I'd say it's probably solved.

@nikomatsakis
Copy link
Contributor

OK, thanks! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-incr-comp Area: Incremental compilation
Projects
None yet
Development

No branches or pull requests

4 participants