Windows stdio doesn't re-read GetStdHandle values #40490
Labels
O-windows
Operating system: Windows
T-libs-api
Relevant to the library API team, which will review and decide on the PR/issue.
Comments
|
There's very little value in caching the result. |
alexcrichton
added a commit
to alexcrichton/rust
that referenced
this issue
Mar 23, 2017
This alters the stdio code on Windows to always call `GetStdHandle` whenever the stdio read/write functions are called as this allows us to track changes to the value over time (such as if a process calls `SetStdHandle` while it's running). Closes rust-lang#40490
steveklabnik
added
T-libs-api
alexcrichton
added a commit
to alexcrichton/rust
that referenced
this issue
Mar 25, 2017
…uron std: Don't cache stdio handles on Windows This alters the stdio code on Windows to always call `GetStdHandle` whenever the stdio read/write functions are called as this allows us to track changes to the value over time (such as if a process calls `SetStdHandle` while it's running). Closes rust-lang#40490
bors
added a commit
that referenced
this issue
Mar 26, 2017
std: Don't cache stdio handles on Windows This alters the stdio code on Windows to always call `GetStdHandle` whenever the stdio read/write functions are called as this allows us to track changes to the value over time (such as if a process calls `SetStdHandle` while it's running). Closes #40490
bors
added a commit
that referenced
this issue
Mar 27, 2017
std: Don't cache stdio handles on Windows This alters the stdio code on Windows to always call `GetStdHandle` whenever the stdio read/write functions are called as this allows us to track changes to the value over time (such as if a process calls `SetStdHandle` while it's running). Closes #40490
alexcrichton
added a commit
to alexcrichton/rust
that referenced
this issue
Mar 27, 2017
…uron std: Don't cache stdio handles on Windows This alters the stdio code on Windows to always call `GetStdHandle` whenever the stdio read/write functions are called as this allows us to track changes to the value over time (such as if a process calls `SetStdHandle` while it's running). Closes rust-lang#40490
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Over time the value of
GetStdHandlemay change (e.g. see mozilla/sccache#80) and we should likely reload the value over time instead of caching the return value to catch cases like this.The text was updated successfully, but these errors were encountered: