Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vec should implement From<&mut [T]> #41386

Closed
adamcrume opened this issue Apr 19, 2017 · 1 comment
Closed

Vec should implement From<&mut [T]> #41386

adamcrume opened this issue Apr 19, 2017 · 1 comment

Comments

@adamcrume
Copy link
Contributor

Vec already has:

impl<'a, T> From<&'a [T]> for Vec<T> where T: Clone

but it should also have:

impl<'a, T> From<&'a mut [T]> for Vec<T> where T: Clone

A workaround is to use Vec::from(my_mut_ref as &[T]).
@Twey
Copy link

Twey commented Apr 19, 2017

Or my_mut_ref.to_vec(). Though the instance would be nice for genericity, of course.

@GuillaumeGomez GuillaumeGomez mentioned this issue Apr 25, 2017
Merged
frewsxcv added a commit to frewsxcv/rust that referenced this issue Apr 26, 2017
@frewsxcv
Rollup merge of rust-lang#41530 - GuillaumeGomez:vec-from, r=aturon
e2a0467 
Implement From<&mut [T]> for Vec

Fixes rust-lang#41386.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Twey @adamcrume