Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tracking issue for TcpStream::connect_timeout #43079

Closed
sfackler opened this issue Jul 6, 2017 · 3 comments
Closed

Tracking issue for TcpStream::connect_timeout #43079

sfackler opened this issue Jul 6, 2017 · 3 comments
Labels
B-unstable Blocker: Implemented in the nightly compiler and unstable. C-tracking-issue Category: A tracking issue for an RFC or an unstable feature. final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.

Comments

@sfackler
Copy link
Member

sfackler commented Jul 6, 2017

Implemented in #43062
@sfackler sfackler added B-unstable Blocker: Implemented in the nightly compiler and unstable. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. labels Jul 6, 2017
@Mark-Simulacrum Mark-Simulacrum added the C-tracking-issue Category: A tracking issue for an RFC or an unstable feature. label Jul 22, 2017
This was referenced Aug 13, 2017
Merged
Merged
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this issue Aug 13, 2017
@GuillaumeGomez
Rollup merge of rust-lang#43833 - dtolnay:connect-timeout, r=sfackler
a7ead41 
Fix TcpStream::connect_timeout tracking issue number

Before: rust-lang#43709
After: rust-lang#43079

r? @sfackler
@sfackler
Copy link
Member Author

@rfcbot fcp merge

@rfcbot
Copy link

rfcbot commented Aug 29, 2017 •
edited by alexcrichton
Loading

Team member @sfackler has proposed to merge this. The next step is review by the rest of the tagged teams:

No concerns currently listed.

Once these reviewers reach consensus, this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

@rfcbot rfcbot added the proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. label Aug 29, 2017
@rfcbot
Copy link

rfcbot commented Sep 12, 2017

🔔 This is now entering its final comment period, as per the review above. 🔔

@rfcbot rfcbot added final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. and removed proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. labels Sep 12, 2017
frewsxcv added a commit to frewsxcv/rust that referenced this issue Sep 15, 2017
@frewsxcv
Rollup merge of rust-lang#44563 - budziq:stablilize_tcpstream_connect…
4af8acd 
…_timeout, r=alexcrichton

stabilize tcpstream_connect_timeout (closes rust-lang#43079)
@bors bors closed this as completed in 199cb82 Sep 15, 2017
dtolnay pushed a commit to dtolnay/rust that referenced this issue Sep 25, 2017
@budziq @dtolnay
stabilize tcpstream_connect_timeout (closes rust-lang#43079)
88063ca
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
B-unstable Blocker: Implemented in the nightly compiler and unstable. C-tracking-issue Category: A tracking issue for an RFC or an unstable feature. final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@sfackler @Mark-Simulacrum @rfcbot