Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fast isel dislikes 1-bit function arguments #4354

Closed
pcwalton opened this issue Jan 5, 2013 · 3 comments
Closed

Fast isel dislikes 1-bit function arguments #4354

pcwalton opened this issue Jan 5, 2013 · 3 comments
Labels
A-codegen Area: Code generation A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. I-slow Issue: Problems and improvements with respect to performance of generated code.
Milestone
0.7

Comments

@pcwalton
Copy link
Contributor

pcwalton commented Jan 5, 2013

This means that any function that calls a Rust function with a bool argument causes a fast isel bailout. We should represent bool as i8.
@alexrp
Copy link

alexrp commented Jan 5, 2013

FWIW, Clang lowers C99 _Bool to i1. I don't know if that has any significance in practice, but I figured I'd mention it...

@sanxiyn
Copy link
Member

sanxiyn commented Mar 29, 2013

Wasn't bool representation changed to i8?

@auroranockert
Copy link
Contributor

This is already implemented.

flip1995 pushed a commit to flip1995/rust that referenced this issue Mar 11, 2021
@bors
Auto merge of rust-lang#6871 - camsteffen:redundant-closure-macro, r=…
2cb5bbf 
…Manishearth

Fix redundant closure with macros

changelog: Fix redundant_closure FPs with macros

Fixes rust-lang#6732
Fixes rust-lang#6850
Fixes rust-lang#4354 (addresses the error message confusion)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-codegen Area: Code generation A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. I-slow Issue: Problems and improvements with respect to performance of generated code.
Projects
None yet
Milestone
0.7
Development

No branches or pull requests
5 participants
@alexrp @sanxiyn @auroranockert @pcwalton @thestinger