Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

De-mode libsyntax and librustc #4364

Closed
pcwalton opened this issue Jan 7, 2013 · 2 comments
Closed

De-mode libsyntax and librustc #4364

pcwalton opened this issue Jan 7, 2013 · 2 comments
Labels
A-codegen Area: Code generation C-cleanup Category: PRs that clean code up or issues documenting cleanup.

Comments

@pcwalton
Copy link
Contributor

pcwalton commented Jan 7, 2013

As it says.
@bstrie bstrie mentioned this issue Mar 7, 2013
Closed
@nikomatsakis
Copy link
Contributor

Not critical for 0.6; removing milestone

@alexcrichton alexcrichton mentioned this issue Apr 19, 2013
Closed
bors added a commit that referenced this issue Apr 20, 2013
@bors
auto merge of #5965 : alexcrichton/rust/issue-4364, r=pcwalton
4ff701b 
This closes #4364. I came into rust after modes had begun to be phased out, so I'm not exactly sure what they all did. My strategy was basically to turn on the compilation warnings and then when everything compiles and passes all the tests it's all good.

In most cases, I just dropped the mode, but in others I converted things to use `&` pointers when otherwise a move would happen.

This depends on #5963. When running the tests, everything passed except for a few compile-fail tests. These tests leaked memory, causing the task to abort differently. By suppressing the ICE from #5963, no leaks happen and the tests all pass. I would have looked into where the leaks were coming from, but I wasn't sure where or how to debug them (I found `RUSTRT_TRACK_ALLOCATIONS`, but it wasn't all that useful).
@alexcrichton
Copy link
Member

I think this can be closed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-codegen Area: Code generation C-cleanup Category: PRs that clean code up or issues documenting cleanup.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@alexcrichton @nikomatsakis @pcwalton @catamorphism