Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove stage0 allocator logic from MSVC in libstd #44217

Closed
alexcrichton opened this issue Aug 31, 2017 · 5 comments
Closed

Remove stage0 allocator logic from MSVC in libstd #44217

alexcrichton opened this issue Aug 31, 2017 · 5 comments
Labels
O-windows-msvc Toolchain: MSVC, Operating system: Windows

Comments

@alexcrichton
Copy link
Member

We're updating the bootstrap compiler in #44154 which attempted to remove the MSVC-specific logic here (added in #43589) but I believe that caused this failure.

No time to debug just yet, but we should remove this one day!

@alexcrichton alexcrichton added the O-windows-msvc Toolchain: MSVC, Operating system: Windows label Aug 31, 2017
@alexcrichton
Copy link
Member Author

cc @aidanhs

@aidanhs
Copy link
Member

aidanhs commented Aug 31, 2017

Well beta-2017-08-29 does seem to have the code in it, so...hmm -

if tcx.sess.allocator_kind.get().is_some() {
for method in ALLOCATOR_METHODS {
local_crate.push((format!("__rust_{}", method.name),
INVALID_DEF_ID,
SymbolExportLevel::Rust));
}
}

@alexcrichton
Copy link
Member Author

Oh I should also clarify that I'm not even sure this is the actual bug. I'm likely to close this after further investigation of updating the bootstrap compiler...

@alexcrichton
Copy link
Member Author

Ok opening a new bug

@alexcrichton
Copy link
Member Author

I opened up #44236, I think this may mean that __rust prefixes are the wrong ones and we're supposed to use the __rg ones, but there's no real motivation to fix this immediately so I'm not going to investigate further.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
O-windows-msvc Toolchain: MSVC, Operating system: Windows
Projects
None yet
Development

No branches or pull requests

2 participants