Meta issue for FIXMEs that reference closed issues #44366

oli-obk · 2017-09-06T13:13:45Z

@Eh2406 compiled this awesome list. I think it should be a meta issue. So here it is

https://gist.github.com/Eh2406/b92f034f8adc193894482e19c79d80f1

Eh2406 · 2017-09-06T13:39:42Z

The good part, this was made with an automated script. I can keep it up-to-date by rerunning as often as we want.

The bad part, it was made with an automated script. Some of these are false positives, like the first one, where the script was too dumb to realize said it's an issue on a different Repository.

In general fees can be fixed by:

Doing what the fix me said to do and seeing if the pr passes
Updating the fix me to refer to a more current issue number
Removing the fix me has the issue was closed won't fix

In the past couple of days I have been reviewing some of these, and if I'm not sure what to do I'v leaving a comment on the clothes issue with a link to the fix me asking for advice.

address some FIXME whose associated issues were marked as closed part of #44366

Eh2406 · 2017-10-06T20:05:22Z

Thanks @nivkner! Let me know when I should rerun the script.

nivkner · 2017-10-07T08:37:37Z

This kind of metabug seems like something that should be tackled continuously, as new FIXMEs are added over time, so if possible this would be better run routinely. Otherwise there really isn't much of a difference between running the script or marking FIXMEs as complete.

Since I wouldn't ask you to dedicate so much time to this one issue, I'd like to know what is your opinion on turning this script into a github bot like "rust-highfive" or "bors". Then whenever an issue is closed, this "FIXME bot" could update this issue.

This comment made sense when it was introduced in fbef241. It does not make sense in its current context, where the referred-to guard is no longer present. This being an item under the fabulous metabug rust-lang#44366.

At reviewer's suggestion, we remove the function/static name from the main lint message. While we're correspondingly adjusting the expectations of a compile-fail test, we remove an obsolete FIXME comment, another quantum of progress towards resolving the fabulous metabug rust-lang#44366.

address more FIXME whose associated issues were marked as closed part of rust-lang#44366

varkor · 2018-01-20T00:33:30Z

It'd be helpful if the code links pointed to specific commit IDs, so that the line numbers remain correct.

Eh2406 · 2018-01-20T20:51:29Z

@varkor thank you for the suggestion. I changed the script to use the sha in the links, and updated the gist to master.

@nivkner It looks like my reply to you never posted, I am very sorry for not replying for so long. I don't have the experience to set up a bot like "rust-highfive" or "bors". So I posted the script I am using so someone with more experience can do that if they like. In the meantime it is no bother for me to run it as needed. I had written up a response like this but apparently it did not post.

nivkner · 2018-01-20T21:11:05Z

Thanks for replying @Eh2406,
Could you please post a link here to the script? I can't find it in your github repositories.
If you don't mind, then could you also post the output of the script, just so we'll know where we are standing after all this time.

Eh2406 · 2018-01-20T21:21:49Z

The gist is at:
https://gist.github.com/Eh2406/b92f034f8adc193894482e19c79d80f1
it has the current (as of today) output and the code.
I posted the code on Oct 14, 2017, the same day I failed to reply hear.

address some FIXME whose associated issues were marked as closed part of rust-lang#44366

Eh2406 · 2018-06-07T17:19:54Z

Just found one not picked up by my script at:

rust/src/libstd/collections/hash/map.rs

Lines 141 to 143 in a86f556

    
           // Annotate exceedingly likely branches in `table::make_hash` 
        
           // and `search_hashed` to reduce instruction cache pressure 
        
           // and mispredictions once it becomes possible (blocked on issue #11092).

Resolve FIXME(rust-lang#27942) [related issue](rust-lang#27942) cc [rust-lang#44366](rust-lang#44366)

ljedrz · 2020-01-07T13:18:17Z

Actually it appears that many of those have already been removed; we could use another pass of that script.

Eh2406 · 2020-01-07T15:32:22Z

The script is still available on the Gist https://gist.github.com/Eh2406/b92f034f8adc193894482e19c79d80f1#file-fixme-py

I stopped running it (when I updated computers) after see this comment https://internals.rust-lang.org/t/compiler-steering-meeting/8588/49 that @pnkfelix and @oli-obk had a more official project.

Maybe we can add this data to that project?

varkor · 2020-01-07T16:13:33Z

For reference, @oli-obk's project is here.

…=Nilstrieb Handle non-utf8 rpaths (fix FIXME) Removes a FIXME for rust-lang#9639 which is closed since long ago. Part of rust-lang#44366 which is E-help-wanted. (Also see rust-lang#114377)

compiletest: Handle non-utf8 paths (fix FIXME) Removes the last FIXME in the code for rust-lang#9639 🎉 (which was closed 8 years ago) Part of rust-lang#44366 which is E-help-wanted. (The other two PRs that does this are rust-lang#114377 and rust-lang#114427)

…=Nilstrieb Handle non-utf8 rpaths (fix FIXME) Removes a FIXME for rust-lang#9639 which is closed since long ago. Part of rust-lang#44366 which is E-help-wanted. (Also see rust-lang#114377)

linkchecker: Remove unneeded FIXME about intra-doc links It was added by rust-lang#77971 but the adder [proposed](rust-lang#77971 (comment)) that the added code is a good fallback to have in case rustdoc gets buggy, and I agree. So remove the FIXME. This PR is part of rust-lang#44366 which is E-help-wanted. r? `@jyn514` since you added the FIXME `@rustbot` label T-dev-tools

…compiler-errors Issue numbers are enforced on active features; remove FIXME Since rust-lang#51090 tidy enforces that active features have an issue number, so remove the FIXME. This PR is part of rust-lang#44366 which is E-help-wanted.

… r=cjgillot Remove FIXME about NLL diagnostic that is already improved The FIXME was added in rust-lang#46984 when the diagnostic message looked like this: // FIXME(rust-lang#46983): error message should be better &s.0 //~ ERROR free region `` does not outlive free region `'static` The message was improved in rust-lang#90667 and now looks like this: &s.0 //~ ERROR lifetime may not live long enough but the FIXME was not removed. The issue rust-lang#46983 about that diagnostics should be improved has been closed. We can remove the FIXME now. (This PR was made for rust-lang#44366.)

…iler-errors tests: Uncomment now valid GAT code behind FIXME The code fails to parse with `nightly-2021-02-05`: $ cargo +nightly-2021-02-05 build error: generic associated types in trait paths are currently not implemented --> src/main.rs:9:42 | 9 | fn _bar<T: for<'a> StreamingIterator<Item<'a> = &'a [i32]>>(_iter: T) { /* ... */ | ^^^^ but parses with `nightly-2021-02-06`: $ cargo +nightly-2021-02-06 build warning: the feature `generic_associated_types` is incomplete and may not be safe to use and/or cause compiler crashes warning: 1 warning emitted because it was (with high probability) fixed by rust-lang#79554 which was merged within that nightly range. This PR is part of rust-lang#44366 which is E-help-wanted.

…tf-8, r=thomcc test_get_dbpath_for_term(): handle non-utf8 paths (fix FIXME) Removes a FIXME for rust-lang#9639 Part of rust-lang#44366 which is E-help-wanted The remaining two FIXMEs for rust-lang#9639 are considerably more complicated, so I will create separate PRs for them.

alexcrichton added the C-cleanup Category: PRs that clean code up or issues documenting cleanup. label Sep 7, 2017

TimNN added the metabug Issues about issues themselves ("bugs about bugs") label Sep 17, 2017

nivkner mentioned this issue Sep 30, 2017

address some FIXME whose associated issues were marked as closed #44943

Merged

bors added a commit that referenced this issue Oct 5, 2017

Auto merge of #44943 - nivkner:fixme_fixup, r=dtolnay

417c738

address some FIXME whose associated issues were marked as closed part of #44366

nivkner mentioned this issue Oct 7, 2017

address more FIXME whose associated issues were marked as closed #45097

Merged

kennytm added a commit to kennytm/rust that referenced this issue Oct 17, 2017

Rollup merge of rust-lang#45097 - nivkner:fixme_fixup2, r=estebank

40d61f5

address more FIXME whose associated issues were marked as closed part of rust-lang#44366

nivkner mentioned this issue Mar 17, 2018

address some FIXME whose associated issues were marked as closed #49117

Merged

kennytm added a commit to kennytm/rust that referenced this issue Mar 21, 2018

Rollup merge of rust-lang#49117 - nivkner:fixme_fixup3, r=estebank

c90871c

address some FIXME whose associated issues were marked as closed part of rust-lang#44366

kennytm added a commit to kennytm/rust that referenced this issue Mar 22, 2018

Rollup merge of rust-lang#49117 - nivkner:fixme_fixup3, r=estebank

8d3f3f0

address some FIXME whose associated issues were marked as closed part of rust-lang#44366

ljedrz mentioned this issue Jul 12, 2018

Resolve FIXME(#27942) #52315

Merged

kennytm added a commit to kennytm/rust that referenced this issue Jul 12, 2018

Rollup merge of rust-lang#52315 - ljedrz:FIXME_#27942, r=petrochenkov

f8039bf

Resolve FIXME(rust-lang#27942) [related issue](rust-lang#27942) cc [rust-lang#44366](rust-lang#44366)

Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this issue Jul 13, 2018

Rollup merge of rust-lang#52315 - ljedrz:FIXME_#27942, r=petrochenkov

82da5ce

Resolve FIXME(rust-lang#27942) [related issue](rust-lang#27942) cc [rust-lang#44366](rust-lang#44366)

kennytm added a commit to kennytm/rust that referenced this issue Jul 13, 2018

Rollup merge of rust-lang#52315 - ljedrz:FIXME_#27942, r=petrochenkov

2fa00da

Resolve FIXME(rust-lang#27942) [related issue](rust-lang#27942) cc [rust-lang#44366](rust-lang#44366)

Munksgaard mentioned this issue Oct 11, 2018

Cleanup rustdoc tests with @!has and @!matches #54824

Merged

jonas-schievink added E-help-wanted Call for participation: Help is requested to fix this issue. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. labels Jan 7, 2020

This was referenced Aug 2, 2023

test_get_dbpath_for_term(): handle non-utf8 paths (fix FIXME) #114377

Merged

Handle non-utf8 rpaths (fix FIXME) #114427

Merged

compiletest: Handle non-utf8 paths (fix FIXME) #114429

Merged

This was referenced Aug 4, 2023

Add a new column Issue states that can be sorted on oli-obk/fixmeh#8

Merged

linkchecker: Remove unneeded FIXME about intra-doc links #114539

Merged

This was referenced Aug 6, 2023

Issue numbers are enforced on active features; remove FIXME #114556

Merged

Remove FIXME about NLL diagnostic that is already improved #114558

Merged

Enselic mentioned this issue Aug 8, 2023

tests: Uncomment now valid GAT code behind FIXME #114629

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Meta issue for FIXMEs that reference closed issues #44366

Meta issue for FIXMEs that reference closed issues #44366

oli-obk commented Sep 6, 2017 •

edited by Eh2406

Loading

Eh2406 commented Sep 6, 2017

Eh2406 commented Oct 6, 2017

nivkner commented Oct 7, 2017 •

edited

Loading

varkor commented Jan 20, 2018

Eh2406 commented Jan 20, 2018

nivkner commented Jan 20, 2018 •

edited

Loading

Eh2406 commented Jan 20, 2018

Eh2406 commented Jun 7, 2018

ljedrz commented Jan 7, 2020

Eh2406 commented Jan 7, 2020

varkor commented Jan 7, 2020

Meta issue for FIXMEs that reference closed issues #44366

Meta issue for FIXMEs that reference closed issues #44366

Comments

oli-obk commented Sep 6, 2017 • edited by Eh2406 Loading

Eh2406 commented Sep 6, 2017

Eh2406 commented Oct 6, 2017

nivkner commented Oct 7, 2017 • edited Loading

varkor commented Jan 20, 2018

Eh2406 commented Jan 20, 2018

nivkner commented Jan 20, 2018 • edited Loading

Eh2406 commented Jan 20, 2018

Eh2406 commented Jun 7, 2018

ljedrz commented Jan 7, 2020

Eh2406 commented Jan 7, 2020

varkor commented Jan 7, 2020

oli-obk commented Sep 6, 2017 •

edited by Eh2406

Loading

nivkner commented Oct 7, 2017 •

edited

Loading

nivkner commented Jan 20, 2018 •

edited

Loading