-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
incr.comp.: Refactor in_scope_traits query to take DefId instead of HirId as query-key #44414
Comments
Oh is There's a few other queries that use |
Well, let's say |
I took a slightly different approach in #44435 which just blanket converts to |
See #44435 (comment). I have not yet looked at the other queries that use |
This'll allow us to reconstruct query parameters purely from the `DepNode` they're associated with. Some queries could move straight to `HirId` but others that don't always have a correspondance between `HirId` and `DefId` moved to two-level maps where the query operates over a `DefIndex`, returning a map, which is then keyed off `ItemLocalId`. Closes rust-lang#44414
rustc: Remove HirId from queries This'll allow us to reconstruct query parameters purely from the `DepNode` they're associated with. Closes #44414
It must be possible for all "input" queries to reconstruct their query-key from their
DepNode
. The easiest way to accomplish this is to make the query-key aDefId
.The
in_scope_traits
query violates this condition at the moment. A simple way to fix this would be to make it a two-level map: The query returns a per-item map that is indexed byItemLocalId
. The query-key would be theHirId::owner
.cc @alexcrichton @nikomatsakis
The text was updated successfully, but these errors were encountered: