concerning Python version for src/etc/char_private.py #45567
Labels
C-enhancement
Category: An issue proposing an enhancement or a PR with one.
Comments
|
If it's just a maintenance script, not normally needed for building the compiler, then I think it's fine to have its own requirements. |
bors
added a commit
that referenced
this issue
Nov 7, 2017
…hton regenerate libcore/char_private.rs (filed separately from the work in #45569, because of this matter of the updated Unicode data; see also #45567) char_private.rs is generated programmatically by char_private.py, using data retrieved from the Unicode Consortium's website. The motivation here was to make `is_printable` crate-visible (with `pub(crate)`), but it would seem that the Unicode data has changed slightly since char_private.rs was last generated.
pietroalbini
added
the
C-enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
src/etc/char_private.py is used to generate src/libcore/char_private.rs (which is checked in to the repository, so the script is to be run by a developer making a change to it, not the build system).
char_private.py requires Python 3.5+—it uses
FileNotFoundError(introduced in Python 3) andsubprocess.run(introduced in Python 3.5)—which is slightly surprising, given that the build dependencies section in the repository's README lists "python2.7 (but not 3.x)".It almost pains me to report this, because if at all possible, I'd rather not edit the script: there is enough Python 2 code in the world; if we are ever to free ourselves from the dead hand of the past, it is intendant on technical pioneers like us to listen when told that the month of July 2010 called while we were out and they want their programming language back. Still, it is valuable to (first and foremost) document and (secondarily) be consistent about what we require.
The text was updated successfully, but these errors were encountered: