Rustdoc: Hide trait impl fn:s on pressing + for types #45720
Labels
C-enhancement
Category: An issue proposing an enhancement or a PR with one.
T-rustdoc
Relevant to the rustdoc team, which will review and decide on the PR/issue.
Comments
|
I can rewrite this as an RFC if required, but I was unsure about the protocol wrt. rustdoc. |
estebank
added
T-rustdoc
|
Similar request: #40363 |
vi
added a commit
to vi/rust
that referenced
this issue
Jan 31, 2018
Addresses rust-lang#40363, rust-lang#45720, rust-lang#24483, rust-lang#23986 and so on * Expands and refactors collapseDocs and toggleAllDocs * Adds [-] toggle to all impls (including inherent impl) * Makes it hiding though main css file, not though element style May need to be addressed: * "[-]" and anchor link copier are overlaid a bit * Inherent methods are also hidden by the global [-] toggle. * Auto-collapsing "Iterator" and so on by default is not implemented yet * Tested only shallowly and only in Chromiuim * No tests. Are there tests for css/js part here? * The new implementation may be a bit slower.
Manishearth
added a commit
to Manishearth/rust
that referenced
this issue
Feb 25, 2018
…umeGomez,QuietMisdreavus rustdoc: Foldable impl blocks Addresses rust-lang#40363, rust-lang#45720, rust-lang#24483, rust-lang#23986 and so on * Expands and refactors collapseDocs and toggleAllDocs * Adds [-] toggle to all impls (including inherent impl) * Makes it hiding though main css file, not though element inline style May need to be addressed: * "[-]" and anchor link copier are overlaid a bit * Inherent methods are also hidden by the global [-] toggle. * Auto-collapsing "Iterator" and so on by default is not implemented yet * Tested only shallowly and only in Chromiuim * No tests. Are there tests for css/js part here? * The new implementation may be a bit slower. What next steps are need to be done before the integration?
bors
added a commit
that referenced
this issue
Feb 28, 2018
…ietMisdreavus rustdoc: Foldable impl blocks Addresses #40363, #45720, #24483, #23986 and so on * Expands and refactors collapseDocs and toggleAllDocs * Adds [-] toggle to all impls (including inherent impl) * Makes it hiding though main css file, not though element inline style May need to be addressed: * "[-]" and anchor link copier are overlaid a bit * Inherent methods are also hidden by the global [-] toggle. * Auto-collapsing "Iterator" and so on by default is not implemented yet * Tested only shallowly and only in Chromiuim * No tests. Are there tests for css/js part here? * The new implementation may be a bit slower. What next steps are need to be done before the integration?
|
Closing as resolved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When pressing the
+hotkey on type's documentation such as on the documentation of Option, the methods of theimplare still shown. This is however mostly useless information that gets in the way of scrolling to see what traits a type implements.It would be more ergonomic if
+would hide every method of every traitimplbut still show all associated items (types and consts) for eachimpl(since they carry useful information).In addition, a
[+]/[-]link should be added on all theimpls (including non-trait impls) either besides[src]or to the left of theimpl(as done withfns this expands and collapses the impls but keeps associated items shown.The text was updated successfully, but these errors were encountered: