Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error in CSS file for https://doc.rust-lang.org/book/ #45974

Closed
ghost opened this issue Nov 14, 2017 · 1 comment
Closed

Error in CSS file for https://doc.rust-lang.org/book/ #45974

ghost opened this issue Nov 14, 2017 · 1 comment
Labels
A-docs Area: documentation for any part of the project, including the compiler, standard library, and tools C-bug Category: This is a bug.

Comments

@ghost
Copy link

ghost commented Nov 14, 2017

Web fonts don't work on this page: https://doc.rust-lang.org/book/ - at least not in Firefox.

Reason: @font-face definitions in CSS file "rust.css" are referring to the wrong level of the file system. The Woff files are stored in "/" -- and not in "/book".

Current (wrong) definition:
src: local('Fira Sans'), url("FiraSans-Regular.woff") format('woff');

It should be:
src: local('Fira Sans'), url("/FiraSans-Regular.woff") format('woff');

Or even better:
src: local('Fira Sans'), url("https://doc.rust-lang.org/FiraSans-Regular.woff") format('woff');

The same is true for all @font-face definitions in the CSS file.

@TimNN TimNN added C-bug Category: This is a bug. A-docs Area: documentation for any part of the project, including the compiler, standard library, and tools labels Nov 14, 2017
@ollie27
Copy link
Member

ollie27 commented Nov 15, 2017

#45998 should fix it.

bors added a commit that referenced this issue Nov 20, 2017
Fix broken CSS for book redirect pages

rust.css has to be next to the font files so we shouldn't copy it for
only the book redirect pages, instead just use the version that is
already there.

This also removes the duplicate code creating version_info.html.

Fixes: #45974
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-docs Area: documentation for any part of the project, including the compiler, standard library, and tools C-bug Category: This is a bug.
Projects
None yet
Development

No branches or pull requests

2 participants