ThinLTO for libstd breaks the leak sanitizer #46126
Labels
C-bug
Category: This is a bug.
Comments
11 tasks
kennytm
added a commit
to kennytm/rust
that referenced
this issue
Nov 28, 2017
Introduced a new src/etc/cat-and-grep.sh script (called in run-make as $(CGREP)), which prints the input and do a grep simultaneously. This is mainly used to debug spurious failures in run-make, such as the sanitizer error in rust-lang#45810, as well as real errors such as rust-lang#46126.
bors
added a commit
that referenced
this issue
Nov 28, 2017
Replace most call to grep in run-make by a script that cat the input. Introduced a new `src/etc/cat-and-grep.sh` script (called in run-make as `$(CGREP)`), which prints the input and do a grep simultaneously. This is mainly used to debug spurious failures in run-make, such as the spurious error in #45810, as well as real errors such as #46126. (cc #40713) Some `grep` still remains, mainly the `grep -c` calls that count the number of matches and print the result to stdout.
|
This issue should be closed. The test case had been rewritten and there haven't been any new failures (previously optimizations enabled by ThinLTO removed memory allocations that were supposed to be leaked). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Discovered in #46008 apparently building libstd with ThinLTO causes the proof-of-concept test of the leak sanitizer to test. The test exits successfully and doesn't print out anything about leaks. I'm going to turn the test off for now as the sanitizers are all unstable.
The text was updated successfully, but these errors were encountered: