Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unnecessary parentheses around argument lint #48717

Closed
Mark-Simulacrum opened this issue Mar 4, 2018 · 3 comments
Closed

Unnecessary parentheses around argument lint #48717

Mark-Simulacrum opened this issue Mar 4, 2018 · 3 comments
Labels
regression-from-stable-to-beta Performance or correctness regression from stable to beta.
Milestone

Comments

@Mark-Simulacrum
Copy link
Member

Mark-Simulacrum commented Mar 4, 2018

This is likely going to be closed as expected breakage. This means those cc-ed below should probably aim to fix their crate and release a new point release.

Due to #46980.

Estimated ecosystem breakage: 3603 versions (4.41% versions published), 551 crates (3.85% of crates). Though technically most/all of this will be fine because of cap lints.

@Mark-Simulacrum Mark-Simulacrum added the regression-from-stable-to-beta Performance or correctness regression from stable to beta. label Mar 4, 2018
@Mark-Simulacrum Mark-Simulacrum added this to the 1.25 milestone Mar 4, 2018
@jonhoo
Copy link
Contributor

jonhoo commented Mar 4, 2018

hdrsample is a deprecated crate that has been entirely replaced by hdrhistogram. I don't know what the policy on such crates is? Some users are still using older versions of it under the old name, and I'd rather not have it be deleted. But it also seems unfortunate to have a crate on crates.io that doesn't compile... I'll issue a point release to the deprecated crate that fixes it, but it'd be unfortunate if I had to continue ensuring that it compiles in perpetuity.

jonhoo added a commit to HdrHistogram/HdrHistogram_rust that referenced this issue Mar 4, 2018
jonhoo added a commit to HdrHistogram/HdrHistogram_rust that referenced this issue Mar 4, 2018
@Mark-Simulacrum
Copy link
Member Author

To be clear, this shouldn't cause downstream crates to not compile -- lint warnings are capped so that while people compiling hdrsample directly won't be able to do so, without code changes, everything should work for people depending on hdrsample.

@Mark-Simulacrum
Copy link
Member Author

I'm going to go ahead and close this as we don't expect to have any further activity on the compiler's side.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
regression-from-stable-to-beta Performance or correctness regression from stable to beta.
Projects
None yet
Development

No branches or pull requests

2 participants