-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rewrite net::ip without using libuv #4956
Comments
not use libuv but directly use something in libc. e.g inet_ntop ? |
Yes, that's what I was thinking. Now that I'm looking at it though, maybe it's not necessary to put all that logic into core. Either way, the determination of what I/O code lives where is something we can revisit later, so we don't need to worry too much about making the wrong decision here. The most important thing is that the abstract I/O types in core can mention IP addresses without depending on libuv. |
Revisited 2013-05-29, still seems legit and properly classified. |
Visiting for triage; nothing to add |
is this still valid/open? |
Don't know enough to do it, I'm afraid; I was trying to find CLs that On Tue, Sep 24, 2013 at 8:49 PM, Jeff Olson notifications@gh.neting.ccwrote:
|
Obsolete |
Some networking definitions are going to need to be defined in core, at least for a while, and that includes IP addresses.
std::net::ip
uses libuv though and I intend not to put uv in core.May block #4419
The text was updated successfully, but these errors were encountered: