Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make logging work with new runtime code #5021

Closed
brson opened this issue Feb 19, 2013 · 2 comments
Closed

Make logging work with new runtime code #5021

brson opened this issue Feb 19, 2013 · 2 comments
Labels
A-runtime Area: std's runtime and "pre-main" init for handling backtraces, unwinds, stack overflows

Comments

@brson
Copy link
Contributor

brson commented Feb 19, 2013

Whatever upcall or lang item rustc is calling for log needs to be updated to figure out exactly how to emit that log. There are several scenarios:

  1. A thread-local rust_task* is available - use the current path
  2. A thread-local Scheduler is available - use some new scheduler-local mechanism
  3. A newsched Task is running - use some new task-local mechanism
  4. There is no available execution context - maybe these should just printf to the console. not sure

Consider redesigning log in the process #3309
@brson brson mentioned this issue Feb 19, 2013
Closed
@brson brson mentioned this issue May 1, 2013
Closed
30 tasks
@brson brson mentioned this issue Jul 11, 2013
Closed
13 tasks
@emberian
Copy link
Member

Visiting for triage; carry on.

@alexcrichton
Copy link
Member

@brson, after glancing at the logging code, this seems done now, but I just wanted to make sure.

bors added a commit to rust-lang-ci/rust that referenced this issue May 2, 2020
@bors
Auto merge of rust-lang#5022 - flip1995:useless_attr, r=phansch
0da0ae3 
Fix useless_attribute suggestion

Fixes rust-lang#5021

changelog: Fix [`useless_attribute`] suggestion, which tripped rustfix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-runtime Area: std's runtime and "pre-main" init for handling backtraces, unwinds, stack overflows
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@alexcrichton @brson @emberian