Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

panic_implementation: Error message talks about the panic_impl lang item when missing #51341

Closed
phil-opp opened this issue Jun 4, 2018 · 1 comment · Fixed by #51921
Closed

Comments

@phil-opp
Copy link
Contributor

phil-opp commented Jun 4, 2018

If the new panic_implementation attribute is missing, the error message mentions the a panic_impl lang item:

error: language item required, but not found: `panic_impl`

Instead it should probably mention that a panic_implementation function is missing.

Edit: Seems like I didn't read it carefully enough. The error message doesn't mention the old panic_fmt language item, but a new panic_impl language item. Either way, a error message mentioning the panic_implementation attribute would be better.

@phil-opp phil-opp changed the title panic_implementation: Error message still talks about the panic_fmt lang item when missing panic_implementation: Error message talks about the panic_impl lang item when missing Jun 4, 2018
@japaric
Copy link
Member

japaric commented Jun 4, 2018

Under the hood we have replaced the old panic_fmt with a new panic_impl lang item but this is an implementation detail of #[panic_implementation]. I think we can special case the error message for missing panic_impl to, instead, mention #[panic_implementation] but, off the top of my head, I don't know where that would be in the code base.

Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this issue Jun 30, 2018
improve the error message when `#[panic_implementation]` is missing

closes rust-lang#51341

r? @nagisa
cc @phil-opp
kennytm added a commit to kennytm/rust that referenced this issue Jun 30, 2018
improve the error message when `#[panic_implementation]` is missing

closes rust-lang#51341

r? @nagisa
cc @phil-opp
pietroalbini added a commit to pietroalbini/rust that referenced this issue Jul 1, 2018
improve the error message when `#[panic_implementation]` is missing

closes rust-lang#51341

r? @nagisa
cc @phil-opp
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants