-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
panic_implementation: Error message talks about the panic_impl lang item when missing #51341
Comments
7 tasks
phil-opp
changed the title
panic_implementation: Error message still talks about the panic_fmt lang item when missing
panic_implementation: Error message talks about the panic_impl lang item when missing
Jun 4, 2018
Under the hood we have replaced the old |
japaric
added a commit
to japaric/rust
that referenced
this issue
Jun 29, 2018
Mark-Simulacrum
added a commit
to Mark-Simulacrum/rust
that referenced
this issue
Jun 30, 2018
improve the error message when `#[panic_implementation]` is missing closes rust-lang#51341 r? @nagisa cc @phil-opp
kennytm
added a commit
to kennytm/rust
that referenced
this issue
Jun 30, 2018
improve the error message when `#[panic_implementation]` is missing closes rust-lang#51341 r? @nagisa cc @phil-opp
pietroalbini
added a commit
to pietroalbini/rust
that referenced
this issue
Jul 1, 2018
improve the error message when `#[panic_implementation]` is missing closes rust-lang#51341 r? @nagisa cc @phil-opp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
If the new
panic_implementation
attribute is missing, the error message mentions the apanic_impl
lang item:Instead it should probably mention that a
panic_implementation
function is missing.Edit: Seems like I didn't read it carefully enough. The error message doesn't mention the old
panic_fmt
language item, but a newpanic_impl
language item. Either way, a error message mentioning thepanic_implementation
attribute would be better.The text was updated successfully, but these errors were encountered: