Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: dead link to std::vec::Vec::extend() #52774

Closed
matthiaskrgr opened this issue Jul 27, 2018 · 10 comments
Closed

docs: dead link to std::vec::Vec::extend() #52774

matthiaskrgr opened this issue Jul 27, 2018 · 10 comments
Labels
T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@matthiaskrgr
Copy link
Member

extend_from_slice links to extend however it seems there is no such method in the docs.

@matthiaskrgr
Copy link
Member Author

matthiaskrgr commented Jul 27, 2018

Ok that is interesting, when I click the link from within the doc, nothing happens, however if I click the link from this issue, I get scrolled to impls. 😕

I'm using firefox 61.0.1

@GuillaumeGomez
Copy link
Member

It's because the method extend is within the Extend trait implementation. Since it's not really an issue, I wonder if we should close it now...

cc @rust-lang/docs

@GuillaumeGomez GuillaumeGomez added the A-docs Area: documentation for any part of the project, including the compiler, standard library, and tools label Jul 28, 2018
@frewsxcv
Copy link
Member

The link is broken in the docs, so I think we should leave this open since we need to fix that.

@GuillaumeGomez
Copy link
Member

GuillaumeGomez commented Jul 28, 2018

No it's not really broken since the link exists: https://doc.rust-lang.org/stable/std/vec/struct.Vec.html#impl-Extend%3CT%3E

The real issue here is that the block doesn't get expanded when you click on the link.

@frewsxcv
Copy link
Member

The real issue here is that the block doesn't get expanded when you click on the link.

Fair enough. If there's an issue already open for that, I'd be in favor of closing this issue in favor of the other one

@GuillaumeGomez
Copy link
Member

I suppose #52517 is the one?

@GuillaumeGomez GuillaumeGomez added T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. and removed A-docs Area: documentation for any part of the project, including the compiler, standard library, and tools labels Jul 31, 2018
@bjorn3
Copy link
Member

bjorn3 commented Aug 7, 2018

Noticed another error in the docs of extend_from_slice:

Note that this function is same as extend except that it is specialized to work with slices instead. If and when Rust gets specialization this function will likely be deprecated (but still available).

extend is already specialized for slices

@GuillaumeGomez
Copy link
Member

@bjorn3 Please open an issue for this one, otherwise it'll get lost.

@bjorn3
Copy link
Member

bjorn3 commented Aug 8, 2018

Sure

@kzys
Copy link
Contributor

kzys commented Aug 23, 2018

#52517 is similar but we need to have the same code for hashchange to address the issue.

https://developer.mozilla.org/en-US/docs/Web/Events/hashchange

kzys added a commit to kzys/rust that referenced this issue Aug 23, 2018
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this issue Aug 26, 2018

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Automatically expand a section even after page load

Fixes rust-lang#52774
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

No branches or pull requests

5 participants