Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deduplicate Cargo in the RLS on CI #53005

Closed
alexcrichton opened this issue Aug 2, 2018 · 3 comments
Closed

Deduplicate Cargo in the RLS on CI #53005

alexcrichton opened this issue Aug 2, 2018 · 3 comments

Comments

@alexcrichton
Copy link
Member

Once #52919 lands we'll have updated the RLS which updates racer, and racer has recently picked up a dependency on the cargo crate. Unfortunately though this is a cargo crate from crates.io, which differs from the src/tools/cargo crate in-tree. This means that when we build the RLS it's linking against two optimized versions of Cargo, which not only takes up a good deal of space but also takes up a good deal of build time.

In talking with @nrc on IRC one solution here would be to avoid using racer's cargo feature. The RLS already depends on cargo-the-crate and should be able to provide the functionality necessary for racer, for example implementing racer's ProjectModelProvider trait

@alexcrichton
Copy link
Member Author

In fixing this we should add a tidy check which ensures that in rust-lang/rust's workspace there's only one entry in the lock file for the cargo crate

@nrc
Copy link
Member

nrc commented Aug 2, 2018

cc racer-rust/racer#914

@mati865
Copy link
Contributor

mati865 commented Aug 2, 2018

cc #52072

kennytm added a commit to kennytm/rust that referenced this issue Mar 2, 2019
Forbid duplicating Cargo as a dependency

Fixes rust-lang#53005
Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this issue Mar 2, 2019
Forbid duplicating Cargo as a dependency

Fixes rust-lang#53005
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants