-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deduplicate Cargo in the RLS on CI #53005
Comments
In fixing this we should add a |
cc #52072 |
kennytm
added a commit
to kennytm/rust
that referenced
this issue
Mar 2, 2019
Forbid duplicating Cargo as a dependency Fixes rust-lang#53005
Mark-Simulacrum
added a commit
to Mark-Simulacrum/rust
that referenced
this issue
Mar 2, 2019
Forbid duplicating Cargo as a dependency Fixes rust-lang#53005
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Once #52919 lands we'll have updated the RLS which updates
racer
, andracer
has recently picked up a dependency on thecargo
crate. Unfortunately though this is acargo
crate from crates.io, which differs from thesrc/tools/cargo
crate in-tree. This means that when we build the RLS it's linking against two optimized versions of Cargo, which not only takes up a good deal of space but also takes up a good deal of build time.In talking with @nrc on IRC one solution here would be to avoid using racer's
cargo
feature. The RLS already depends oncargo
-the-crate and should be able to provide the functionality necessary for racer, for example implementing racer'sProjectModelProvider
traitThe text was updated successfully, but these errors were encountered: