Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Why doesn't std::net::SocketAddr implement std::cmp::Ord and std::cmp::PartialOrd? #53710

Closed
In-line opened this issue Aug 25, 2018 · 0 comments · Fixed by #72239
Closed

Why doesn't std::net::SocketAddr implement std::cmp::Ord and std::cmp::PartialOrd? #53710

In-line opened this issue Aug 25, 2018 · 0 comments · Fixed by #72239
Labels
C-feature-request Category: A feature request, i.e: not implemented / a PR. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.

Comments

@In-line
Copy link
Contributor

In-line commented Aug 25, 2018

It seems to me a bug, because std::net::IpAddr implements std::cmp::Ord and std::cmp::PartialOrd.
@frewsxcv frewsxcv added the T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. label Aug 25, 2018
tbu- added a commit to tbu-/rust that referenced this issue Aug 29, 2018
@tbu-
Add PartialOrd and Ord implementation for std::net::SocketAddr
dd4c0eb 
Fixes rust-lang#53710.
@tbu- tbu- mentioned this issue Aug 29, 2018
Closed
@In-line In-line mentioned this issue Aug 31, 2018
Closed
@JohnTitor JohnTitor added the C-feature-request Category: A feature request, i.e: not implemented / a PR. label Oct 19, 2019
@hch12907 hch12907 mentioned this issue May 15, 2020
Merged
@bors bors closed this as completed in b18c55b May 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-feature-request Category: A feature request, i.e: not implemented / a PR. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement PartialOrd and Ord for SocketAddr* hch12907/rust
3 participants
@frewsxcv @In-line @JohnTitor