Linter suggestion breaks compilation #53925
Assignees
Labels
A-edition-2018-lints
Area: Lints supporting the 2018 edition
A-lint
Area: Lints (warnings about flaws in source code) such as unused_mut.
A-suggestion-diagnostics
Area: Suggestions generated by the compiler applied by `cargo fix`
Comments
|
The unreachable-pub lint was removed from the 2018-idioms lint group in #52926 because it suffers from the bugs #47816 (which is the cause of the problem in your first example) and #52665, but this change won't be in stable until 1.29 (13 September). Until we have a release candidate, the nightly toolchain might be a better choice for testing out edition-2018 features. |
estebank
added
A-lint
Centril
added a commit
to Centril/rust
that referenced
this issue
Jan 28, 2019
Update visibility of intermediate use items. Fixes rust-lang#57410 and fixes rust-lang#53925 and fixes rust-lang#47816. Currently, the target of a use statement will be updated with the visibility of the use statement itself (if the use statement was visible). This PR ensures that if the path to the target item is via another use statement then that intermediate use statement will also have the visibility updated like the target. This silences incorrect `unreachable_pub` lints with inactionable suggestions.
bors
added a commit
that referenced
this issue
Feb 3, 2019
Update visibility of intermediate use items. Fixes #57410 and fixes #53925 and fixes #47816. Currently, the target of a use statement will be updated with the visibility of the use statement itself (if the use statement was visible). This PR ensures that if the path to the target item is via another use statement then that intermediate use statement will also have the visibility updated like the target. This silences incorrect `unreachable_pub` lints with inactionable suggestions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I define
#![deny(rust_2018_idioms)]which implies#![deny(unreachable_pub)]and I got linter complaining about thepub useinside private module while I reexport the symbol at crate level.Here is a small example of what I'm talking about
Looks ok. Let's do what linter suggests - change
pubtopub(crate)and...Get compilation error with '
Baris private'Here is how it looks like
What is the correct way to export
Barin example? My guess is that second variant is correct, hence linter is correct as well, and the bug is in visibility system somewhere inrustc. But I'm not an expert here.The text was updated successfully, but these errors were encountered: