Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1.30.0-beta cannot bootstrap itself #54322

Closed
Keruspe opened this issue Sep 18, 2018 · 0 comments
Closed

1.30.0-beta cannot bootstrap itself #54322

Keruspe opened this issue Sep 18, 2018 · 0 comments
Labels
T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Comments

@Keruspe
Copy link
Contributor

Keruspe commented Sep 18, 2018 •
edited
Loading

Current beta (14f51b0) cannot bootstrap itself.
The cargo version shipped with it appends --color=always when the output terminal supports it, and src/bootstrap/compile.rs sets RUSTC_COLOR=1 leading to src/boostrap/bin/rustc.rs also appending --color=always.
This results in commands like:

rustc command: "LD_LIBRARY_PATH"="/usr/host/lib:/var/tmp/paludis/build/dev-lang-rust-1.30.0-scm/work/rust-1.30.0-scm/build/x86_64-unknown-linux-gnu/stage0-std/release/deps:/usr/x86_64-pc-linux-gnu/lib" "/usr/host/bin/rustc-beta" "--crate-name" "cc" "/var/cache/paludis/distfiles/cargo-home/registry/src/gh.neting.cc-1ecc6299db9ec823/cc-1.0.22/src/lib.rs" "--color" "always" "--crate-type" "lib" "--emit=dep-info,link" "-C" "opt-level=2" "-C" "metadata=31edc2328efb244d-rustc" "-C" "extra-filename=-31edc2328efb244d" "--out-dir" "/var/tmp/paludis/build/dev-lang-rust-1.30.0-scm/work/rust-1.30.0-scm/build/x86_64-unknown-linux-gnu/stage0-std/release/deps" "-L" "dependency=/var/tmp/paludis/build/dev-lang-rust-1.30.0-scm/work/rust-1.30.0-scm/build/x86_64-unknown-linux-gnu/stage0-std/release/deps" "--cap-lints" "allow" "--cfg" "stage1" "-Clinker=x86_64-pc-linux-gnu-cc" "-C" "target-feature=-crt-static" "--color=always"

which in turn leads to

error: Option 'color' given more than once
error: Could not compile `cc`
@Keruspe Keruspe mentioned this issue Sep 18, 2018
Merged
@estebank estebank added the T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) label Sep 19, 2018
kennytm added a commit to kennytm/rust that referenced this issue Sep 21, 2018
@kennytm
Rollup merge of rust-lang#54323 - Keruspe:rustc-color, r=Mark-Simulacrum
da28ae2 
rustbuild: drop color handling

Let cargo handle that for us

Fixes rust-lang#54322

Needs a beta backport
pietroalbini added a commit to pietroalbini/rust that referenced this issue Sep 22, 2018
@pietroalbini
Rollup merge of rust-lang#54323 - Keruspe:rustc-color, r=Mark-Simulacrum
e59df62 
rustbuild: drop color handling

Let cargo handle that for us

Fixes rust-lang#54322

Needs a beta backport
@Keruspe Keruspe mentioned this issue Aug 27, 2019
Closed
@symphorien symphorien mentioned this issue Jan 7, 2021
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Keruspe @estebank