Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Broken links in compiler internal docs #56107

Closed
bjorn3 opened this issue Nov 20, 2018 · 0 comments · Fixed by #56441
Closed

Broken links in compiler internal docs #56107

bjorn3 opened this issue Nov 20, 2018 · 0 comments · Fixed by #56441

Comments

@bjorn3
Copy link
Member

bjorn3 commented Nov 20, 2018

Take for example https://doc.rust-lang.org/nightly/nightly-rustc/rustc_codegen_ssa/traits/consts/trait.ConstMethods.html:

If you click on a reference to LocalInternedString you will be send to https://doc.rust-lang.org/nightly/syntax_pos/symbol/struct.LocalInternedString.html. Note the missing /nightly-rustc/.

This happens at other places too.
@ollie27 ollie27 mentioned this issue Dec 2, 2018
Merged
kennytm added a commit to kennytm/rust that referenced this issue Dec 4, 2018
@kennytm
Rollup merge of rust-lang#56441 - ollie27:rustbuild_compiler_docs, r=…
3dfaeab 
…alexcrichton

rustbuild: Fix issues with compiler docs

* Create output directories for crates beforehand so rustdoc uses relative links (fixes rust-lang#56107)
* Readd rustc_codegen_ssa (fixes rust-lang#56196)
* Don't build out of tree dependencies for rustdoc like we don't for rustc
kennytm added a commit to GuillaumeGomez/rust that referenced this issue Dec 5, 2018
@kennytm
Rollup merge of rust-lang#56441 - ollie27:rustbuild_compiler_docs, r=…
096c434 
…alexcrichton

rustbuild: Fix issues with compiler docs

* Create output directories for crates beforehand so rustdoc uses relative links (fixes rust-lang#56107)
* Readd rustc_codegen_ssa (fixes rust-lang#56196)
* Don't build out of tree dependencies for rustdoc like we don't for rustc
pietroalbini added a commit to pietroalbini/rust that referenced this issue Dec 6, 2018
@pietroalbini
Rollup merge of rust-lang#56441 - ollie27:rustbuild_compiler_docs, r=…
0be8537 
…alexcrichton

rustbuild: Fix issues with compiler docs

* Create output directories for crates beforehand so rustdoc uses relative links (fixes rust-lang#56107)
* Readd rustc_codegen_ssa (fixes rust-lang#56196)
* Don't build out of tree dependencies for rustdoc like we don't for rustc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

rustbuild: Fix issues with compiler docs ollie27/rust
1 participant
@bjorn3