Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking issue for std::ptr::hash #56286

Closed
dwijnand opened this issue Nov 27, 2018 · 7 comments · Fixed by #59603
Closed

Tracking issue for std::ptr::hash #56286

dwijnand opened this issue Nov 27, 2018 · 7 comments · Fixed by #59603
Labels
B-unstable Blocker: Implemented in the nightly compiler and unstable. C-tracking-issue Category: A tracking issue for an RFC or an unstable feature. disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. finished-final-comment-period The final comment period is finished for this PR / Issue. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.

Comments

@dwijnand
Copy link
Member

Implemented in #56250 as #[unstable(feature = "ptr_hash")].

@Centril Centril added T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. C-tracking-issue Category: A tracking issue for an RFC or an unstable feature. labels Nov 27, 2018
@alexcrichton alexcrichton added the B-unstable Blocker: Implemented in the nightly compiler and unstable. label Dec 4, 2018
@dtolnay
Copy link
Member

dtolnay commented Dec 13, 2018

Updated from:

fn hash<T, S: Hasher>(hashee: *const T, into: &mut S)

to:

fn hash<T: ?Sized, S: Hasher>(hashee: *const T, into: &mut S)
           ^^^^^^

in #56751. Thanks @mbrubeck.

@SimonSapin
Copy link
Contributor

Seems straightforward enough to me.

@rfcbot fcp merge

@rfcbot
Copy link

rfcbot commented Feb 1, 2019

Team member @SimonSapin has proposed to merge this. The next step is review by the rest of the tagged team members:

No concerns currently listed.

Once a majority of reviewers approve (and none object), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

@rfcbot rfcbot added proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. labels Feb 1, 2019
@rfcbot
Copy link

rfcbot commented Feb 8, 2019

🔔 This is now entering its final comment period, as per the review above. 🔔

@rfcbot rfcbot added final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. and removed proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. labels Feb 8, 2019
@rfcbot rfcbot added the finished-final-comment-period The final comment period is finished for this PR / Issue. label Feb 18, 2019
@rfcbot
Copy link

rfcbot commented Feb 18, 2019

The final comment period, with a disposition to merge, as per the review above, is now complete.

@rfcbot rfcbot removed the final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. label Feb 18, 2019
@Centril Centril added the E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. label Mar 26, 2019
matklad added a commit to matklad/rust that referenced this issue Apr 1, 2019
Centril added a commit to Centril/rust that referenced this issue Apr 1, 2019
@matklad
Copy link
Member

matklad commented Jul 3, 2019

Question:

We have Arc::ptr_eq, should we have Arc::ptr_hash as well?

@SimonSapin
Copy link
Contributor

We could, but that’s going quickly into diminishing returns IMO. You can always use something like std::ptr::hash::<T, _>(&*arc, s)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B-unstable Blocker: Implemented in the nightly compiler and unstable. C-tracking-issue Category: A tracking issue for an RFC or an unstable feature. disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. finished-final-comment-period The final comment period is finished for this PR / Issue. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants