-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tracking issue for DoubleEndedIterator::nth_back #56995
Comments
Ping @alexcrichton (or whomever) to add the appropriate labels to this. |
Implement specialized nth_back() for Box and Windows. Hi there, this is my first pull request to rust :-) I started implementing some specializations for DoubleEndedIterator::nth_back() and these are the first two. The problem has been discussed in rust-lang#54054 and nth_back() is tracked in rust-lang#56995. I'm stuck with the next implementation so I though I do a PR for the ones I'm confident with to get some feedback.
Team member @SimonSapin has proposed to merge this. The next step is review by the rest of the tagged team members: No concerns currently listed. Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up! See this document for info about what commands tagged team members can give me. |
🔔 This is now entering its final comment period, as per the review above. 🔔 |
The final comment period, with a disposition to merge, as per the review above, is now complete. As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed. The RFC will be merged soon. |
…entril Stabilize iter_nth_back feature FCP done in rust-lang#56995 (comment) Closes rust-lang#56995 r? @Centril
…entril Stabilize iter_nth_back feature FCP done in rust-lang#56995 (comment) Closes rust-lang#56995 r? @Centril
Hello, I'm getting this error suddenly which points to this issue. Any clue how to fix it? Thanks! Compiling lock_api v0.3.1 error[E0658]: use of unstable library feature 'iter_nth_back' |
Are you using an up to date nightly? |
|
PR: #56802
Currently, none of the standard adapters specialise this except for
Rev
, which trivially swapsnth
andnth_back
. These should probably be added before this feature is stabilised, and it's probably a good idea to check ifnth
should be specialised for any of these adapters too.Additionally, the standard collection iterators should specialise this where appropriate.
The text was updated successfully, but these errors were encountered: