Tracking issue for PathBuf capacity methods #58234

Mark-Simulacrum · 2019-02-06T16:45:08Z

capacity
with_capacity
clear
reserve
reserve_exact
shrink_to_fit
shrink_to, should probably not be stabilized before OsString::shrink_to, see Tracking issue for shrink_to feature #56431

The text was updated successfully, but these errors were encountered:

aaronstillwell · 2019-02-06T20:07:15Z

Happy to take this on as a first contribution to rust.

aaronstillwell · 2019-02-11T16:43:13Z

@Mark-Simulacrum are you able to define a list of the methods that need to be implemented as part of this PR?

Mark-Simulacrum · 2019-02-11T19:44:08Z

I think all of these will essentially call the underlying functions on OsString.

We'll probably want to add all of these under the same feature gate.

aaronstillwell · 2019-02-14T17:59:39Z

@Mark-Simulacrum thanks for that. I have the implementation drafted locally. I'm having some difficulty however in running the tests for stdlib - even a cargo check is producing errors not related to my changes. Is there any documentation I've missed for best practices on compiling / working on stdlib?

@Mark-Simulacrum

…acrum Add alias methods to PathBuf for underlying OsString (rust-lang#58234) Implemented the following methods on PathBuf which forward to the underlying OsString. - capacity - with_capacity - clear - reserve - reserve_exact - shrink_to_fit - shrink_to These methods have been documented with reference to the original docs for `OsString`. @Mark-Simulacrum please let me know if you feel this does not suffice. Further, I've not yet included tests for these definitions - please advise on how comprehensive tests need to be for methods such as these that simply alias other (already tested) methods. (This PR addresses issue rust-lang#58234)

@Mark-Simulacrum

…acrum Add alias methods to PathBuf for underlying OsString (rust-lang#58234) Implemented the following methods on PathBuf which forward to the underlying OsString. - capacity - with_capacity - clear - reserve - reserve_exact - shrink_to_fit - shrink_to These methods have been documented with reference to the original docs for `OsString`. @Mark-Simulacrum please let me know if you feel this does not suffice. Further, I've not yet included tests for these definitions - please advise on how comprehensive tests need to be for methods such as these that simply alias other (already tested) methods. (This PR addresses issue rust-lang#58234)

@Mark-Simulacrum

…acrum Add alias methods to PathBuf for underlying OsString (rust-lang#58234) Implemented the following methods on PathBuf which forward to the underlying OsString. - capacity - with_capacity - clear - reserve - reserve_exact - shrink_to_fit - shrink_to These methods have been documented with reference to the original docs for `OsString`. @Mark-Simulacrum please let me know if you feel this does not suffice. Further, I've not yet included tests for these definitions - please advise on how comprehensive tests need to be for methods such as these that simply alias other (already tested) methods. (This PR addresses issue rust-lang#58234)

Rollup of 24 pull requests Successful merges: - #56470 (Modify doctest's auto-`fn main()` to allow `Result`s) - #58044 (Make overflowing and wrapping negation const) - #58303 (Improve stability tags display) - #58336 (Fix search results interactions) - #58384 (Fix tables display) - #58392 (Use less explicit shifting in std::net::ip) - #58409 (rustdoc: respect alternate flag when formatting impl trait) - #58456 (Remove no longer accurate diagnostic code about NLL) - #58528 (Don't use an allocation for ItemId in StmtKind) - #58530 (Monomorphize less code in fs::{read|write}) - #58534 (Mention capping forbid lints) - #58536 (Remove UB in pointer tests) - #58538 (Add missing fmt structs examples) - #58539 (Add alias methods to PathBuf for underlying OsString (#58234)) - #58544 (Fix doc for rustc "-g" flag) - #58545 (Add regression test for a specialization-related ICE (#39448)) - #58546 (librustc_codegen_llvm => 2018) - #58551 (Explain a panic in test case net::tcp::tests::double_bind) - #58553 (Use more impl header lifetime elision) - #58562 (Fix style nits) - #58565 (Fix typo in std::future::Future docs) - #58568 (Fix a transposition in driver.rs.) - #58569 (Reduce Some Code Repetitions like `(n << amt) >> amt`) - #58576 (Stabilize iter::successors and iter::from_fn)

Mark-Simulacrum · 2019-07-28T18:22:18Z

Reviewing this since then, I think it may be worth removing these APIs and replacing them with something like AsRef<OsString> for PathBuf and AsMut. These aren't really commonly used so hiding them as such seems reasonable and is less heavy.

kornelski · 2020-04-08T21:57:42Z

I'd love to see these stabilized. I have a tool that manipulates lots of paths, so I'd like to avoid needless reallocations.

I generate lots of temporary paths in a loop. PathBuf.clear() + PathBuf.push() would work nicely to reuse the buffer.
I need to concatenate several components. I know their length, so I could use PathBuf::with_capacity()
I want to store lots of paths for later. Box<Path> is a bit smaller than PathBuf, but if I can't reserve exact capacity, into() will reallocate.

Amanieu · 2020-04-08T22:29:02Z

@rfcbot merge

rfcbot · 2020-04-08T22:29:05Z

Team member @Amanieu has proposed to merge this. The next step is review by the rest of the tagged team members:

No concerns currently listed.

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

dtolnay · 2020-04-08T23:00:37Z

@rfcbot reviewed
assuming we're only stabilizing capacity + with_capacity + clear + reserve + reserve_exact + shrink_to_fit; and shrink_to is being moved to #56431 instead.

rfcbot · 2020-04-09T06:10:11Z

🔔 This is now entering its final comment period, as per the review above. 🔔

rfcbot · 2020-04-19T06:10:59Z

The final comment period, with a disposition to merge, as per the review above, is now complete.

As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed.

The RFC will be merged soon.

Mark-Simulacrum · 2020-04-19T16:01:43Z

I've posted a stabilization PR in #71328.

…apacity, r=sfackler Stabilize PathBuf capacity methods Closes rust-lang#58234. Stabilization FCP finished in rust-lang#58234 (comment).

Mark-Simulacrum mentioned this issue Feb 6, 2019

Implement HeapSizeOf for PathBuf and friends servo/heapsize#99

Open

This comment has been minimized.

Sign in to view

aaronstillwell mentioned this issue Feb 17, 2019

Add alias methods to PathBuf for underlying OsString (#58234) #58539

Merged

GuillaumeGomez mentioned this issue Feb 17, 2019

Rollup of 7 pull requests #58550

Closed

Mark-Simulacrum mentioned this issue Feb 18, 2019

Rollup of 16 pull requests #58566

Closed

kennytm mentioned this issue Feb 19, 2019

Rollup of 24 pull requests #58578

Merged

This comment has been minimized.

Sign in to view

Mark-Simulacrum added C-tracking-issue Category: An issue tracking the progress of sth. like the implementation of an RFC and removed C-feature-accepted Category: A feature request that has been accepted pending implementation. labels Mar 1, 2019

Mark-Simulacrum changed the title ~~Add PathBuf capacity methods~~ Tracking issue for PathBuf capacity methods Mar 1, 2019

Mark-Simulacrum removed the E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. label Mar 1, 2019

This comment has been minimized.

Sign in to view

jonas-schievink added the B-unstable Blocker: Implemented in the nightly compiler and unstable. label Nov 26, 2019

rfcbot added proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. labels Apr 8, 2020

rfcbot added final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. and removed proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. labels Apr 9, 2020

rfcbot added the finished-final-comment-period The final comment period is finished for this PR / Issue. label Apr 19, 2020

rfcbot removed the final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. label Apr 19, 2020

Mark-Simulacrum mentioned this issue Apr 19, 2020

Stabilize PathBuf capacity methods #71328

Merged

bors closed this as completed in 7561714 Apr 20, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Tracking issue for PathBuf capacity methods #58234

Tracking issue for PathBuf capacity methods #58234

Mark-Simulacrum commented Feb 6, 2019 •

edited

Loading

aaronstillwell commented Feb 6, 2019 •

edited

Loading

This comment has been minimized.

aaronstillwell commented Feb 11, 2019

Mark-Simulacrum commented Feb 11, 2019

aaronstillwell commented Feb 14, 2019

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Mark-Simulacrum commented Jul 28, 2019

kornelski commented Apr 8, 2020

Amanieu commented Apr 8, 2020

rfcbot commented Apr 8, 2020 •

edited by SimonSapin

Loading

dtolnay commented Apr 8, 2020

rfcbot commented Apr 9, 2020

rfcbot commented Apr 19, 2020

Mark-Simulacrum commented Apr 19, 2020

Tracking issue for PathBuf capacity methods #58234

Tracking issue for PathBuf capacity methods #58234

Comments

Mark-Simulacrum commented Feb 6, 2019 • edited Loading

aaronstillwell commented Feb 6, 2019 • edited Loading

This comment has been minimized.

aaronstillwell commented Feb 11, 2019

Mark-Simulacrum commented Feb 11, 2019

aaronstillwell commented Feb 14, 2019

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Mark-Simulacrum commented Jul 28, 2019

kornelski commented Apr 8, 2020

Amanieu commented Apr 8, 2020

rfcbot commented Apr 8, 2020 • edited by SimonSapin Loading

dtolnay commented Apr 8, 2020

rfcbot commented Apr 9, 2020

rfcbot commented Apr 19, 2020

Mark-Simulacrum commented Apr 19, 2020

Mark-Simulacrum commented Feb 6, 2019 •

edited

Loading

aaronstillwell commented Feb 6, 2019 •

edited

Loading

rfcbot commented Apr 8, 2020 •

edited by SimonSapin

Loading